[SERVER-36169] Resmoke: bare raise outside except in the stepdown hook Created: 17/Jul/18 Updated: 29/Oct/23 Resolved: 27/Aug/18 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Testing Infrastructure |
| Affects Version/s: | None |
| Fix Version/s: | 4.0.3, 4.1.3 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Yves Duhem | Assignee: | Jonathan Abrahams |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||
| Operating System: | ALL | ||||||||||||
| Backport Requested: |
v4.0, v3.6
|
||||||||||||
| Sprint: | TIG 2018-09-10 | ||||||||||||
| Participants: | |||||||||||||
| Story Points: | 1 | ||||||||||||
| Description |
|
The stepdown hook code contains three misplaced bare raise statement, outside an except block: here, here and here. |
| Comments |
| Comment by Githook User [ 28/Aug/18 ] | ||||
|
Author: {'name': 'Jonathan Abrahams', 'email': 'jonathan@mongodb.com', 'username': 'hptabster'}Message: (cherry picked from commit 2749a04cc4de675a3490d996cd546867b32577d8) | ||||
| Comment by Githook User [ 27/Aug/18 ] | ||||
|
Author: {'name': 'Jonathan Abrahams', 'email': 'jonathan@mongodb.com', 'username': 'hptabster'}Message: | ||||
| Comment by Max Hirschhorn [ 02/Aug/18 ] | ||||
|
In all of these locations it looks like we should be raising an appropriate exception type ourselves. There is no active exception to reraise.
is the output we'd see if we were actually hitting any of those lines. |