[SERVER-36243] Take advantage of c++14 sized delete facilities in tc_malloc Created: 23/Jul/18 Updated: 11/May/23 Resolved: 25/Mar/19 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Internal Code, Performance |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Mathias Stearn | Assignee: | Henrik Edin |
| Resolution: | Duplicate | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||||||
| Sprint: | Dev Tools 2019-02-25, Dev Tools 2019-03-11, Dev Tools 2019-03-25 | ||||||||||||||||||||||||||||
| Participants: | |||||||||||||||||||||||||||||
| Linked BF Score: | 16 | ||||||||||||||||||||||||||||
| Description |
|
Google reported substantial performance improvement by adopting sized delete.
Tasks:
|
| Comments |
| Comment by Andrew Morrow (Inactive) [ 25/Mar/19 ] |
|
Re-closing as a duplicate of |
| Comment by Githook User [ 18/Mar/19 ] |
|
Author: {'email': 'acm@mongodb.com', 'name': 'Andrew Morrow', 'username': 'acmorrow'}Message: Revert " This reverts commit afe082642124dbda2367cb51c3d748873df9bf7b. |
| Comment by Githook User [ 12/Mar/19 ] |
|
Author: {'name': 'Henrik Edin', 'email': 'henrik.edin@mongodb.com', 'username': 'henrikedin'}Message: Added mongoFree to be used when allocating memory with mongoMalloc. |
| Comment by Bruce Lucas (Inactive) [ 08/Feb/19 ] |
|
We should also check whether this plays well with the built-in heap profiler (util/heap_profiler.cpp). I expect it should because the heap profiler hooks in at a lower level of tcmalloc, but it's worth checking to be sure. |
| Comment by Andrew Morrow (Inactive) [ 25/Jan/19 ] |
|
Also need to remember to pass in the --enable-sized-delete or windows equivalent when configuring (and investigate what is needed in the toolchain flags as well (-fsized-deallocation or /Zc:sizedDealloc. |
| Comment by Andrew Morrow (Inactive) [ 25/Jan/19 ] |
|
This should also include rebuilding all configs with v3 toolchain. |