[SERVER-36256] Make "wiredTiger" default value for jsTest.options().storageEngine Created: 24/Jul/18  Updated: 06/Dec/22

Status: Backlog
Project: Core Server
Component/s: Testing Infrastructure
Affects Version/s: None
Fix Version/s: None

Type: Improvement Priority: Major - P3
Reporter: Ian Boros Assignee: Backlog - Server Tooling and Methods (STM) (Inactive)
Resolution: Unresolved Votes: 0
Labels: stm, tig-qwin-eligible
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
related to SERVER-36337 Prevent explain_sample.js from being ... Closed
is related to SERVER-39362 Make parallel/basic.js test respect r... Closed
Assigned Teams:
Server Tooling & Methods
Participants:

 Description   

A lot of JS tests do this kind of check:

if (jsTest.options().storageEngine && jsTest.options().storageEngine !== "wiredTiger") {
// skip the test
}

I just found this test test (which I reviewed!) that doesn't include the "is the 'storageEngine' falsy" check. The result is that when you run that test in the core suite, it will be skipped.

I think we should just make the default value for 'storageEngine' be 'wiredTiger' and then we won't need to worry about tests being skipped erroneously.



 Comments   
Comment by Steven Vannelli [ 10/May/22 ]

Moving this ticket to the Backlog and removing the "Backlog" fixVersion as per our latest policy for using fixVersions.

Comment by Ian Boros [ 22/Aug/18 ]

max.hirschhorn That's a good thought, but I don't think it'll work because as far as I know the parallel tests aren't aware of tags. See SERVER-36181.

Comment by Max Hirschhorn [ 22/Aug/18 ]

ian.boros, is there a reason now that we couldn't have tagged the jstests/core/explain_sample.js test as "requires_wiredtiger"? Now that we have switched over to a single storage engine per build variant model in our Evergreen configuration, I wonder if we even need to write this style of if-statement anymore. It does seem like something that could come up when only part of the test cannot be run against non-WiredTiger storage engines.

Generated at Thu Feb 08 04:42:33 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.