[SERVER-36307] Remove MultiIndexBlockImpl::insertAllDocumentsInCollection function parameter that is always a nullptr Created: 26/Jul/18 Updated: 29/Oct/23 Resolved: 02/Aug/18 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Storage |
| Affects Version/s: | None |
| Fix Version/s: | 4.1.2 |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Dianna Hohensee (Inactive) | Assignee: | Audrey Fang (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | neweng | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Backwards Compatibility: | Fully Compatible |
| Sprint: | Storage NYC 2018-08-13 |
| Participants: |
| Description |
|
No callers of MultiIndexBlockImpl::insertAllDocumentsInCollection(std::set<RecordId>* dupsOut = nullptr), except for an index unit test, pass in a function parameter. They all let the function parameter default to nullptr. I suspect that this field was outdated with the introduction of the 'unique' index build setting. A build will handle the issue of duplicates internally, succeeding or failing depending on settings that were passed into the index build request. |
| Comments |
| Comment by Githook User [ 02/Aug/18 ] |
|
Author: {'name': 'Audrey Fang', 'email': 'audrey.fang@10gen.com', 'username': 'audreyfang'}Message: |