[SERVER-36351] ServiceContextMongoDTest doesn't persist TempDir correctly Created: 30/Jul/18  Updated: 29/Oct/23  Resolved: 08/Aug/18

Status: Closed
Project: Core Server
Component/s: Internal Code
Affects Version/s: None
Fix Version/s: 4.0.3, 4.1.2

Type: Bug Priority: Major - P3
Reporter: Eric Milkie Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Problem/Incident
is caused by SERVER-34798 Replace subclasses of ServiceContext ... Closed
Backwards Compatibility: Fully Compatible
Operating System: ALL
Sprint: Platforms 2018-08-13
Participants:

 Description   

In ServiceContextMongoDTest::ServiceContextMongoDTest(), it puts a unittest::TempDir on the stack. This seems unintentional, as the code immediately removes the temporary directory when the constructor finishes.
The code still "works" on Linux because the storage engine has already opened all the files it needs by that point, so it never notices the directory got deleted.
On Windows, the tests are working because the removal of the temp directory fails, since there are still open files in the directory. This results in any unit test utilizing ServiceContextMongoDTest on Windows to have their logs filled with copious warnings:

[cpp_unit_test:lock_manager_test] 2018-07-27T07:26:08.819+0000 Starting C++ unit test build\cached\mongo\db\concurrency\lock_manager_test.exe...
...
[cpp_unit_test:lock_manager_test] 2018-07-27T07:26:09.701+0000 2018-07-27T07:26:09.702+0000 W -        [main] error encountered recursively deleting directory 'C:\data\tmp\service_context_d_test_fixture-a59a-a817-07f1-c6e4': boost::filesystem::remove: The process cannot access the file because it is being used by another process: "C:\data\tmp\service_context_d_test_fixture-a59a-a817-07f1-c6e4\mongod.lock". Ignoring and continuing.
...

(And I believe the test ends up littering the Windows test machines with many temp directories.)



 Comments   
Comment by Githook User [ 13/Sep/18 ]

Author:

{'name': 'Henrik Edin', 'email': 'henrik.edin@mongodb.com', 'username': 'henrikedin'}

Message: SERVER-34798 Remove ServiceContext subclasses and use new ServiceContext in every unit test.

This patch does several loosely related and surprisingly hard to separate things.

1.) Make the ServiceContext class final

2.) Create a mechanism, called ConstructorActions, for running methods on
ServiceContexts immediately after they're built and immediately before they're
destroyed.

3.) Introduce / improve test fixture base classes for tests, giving them fresh
ServiceContext instances for each test case. There is one fixture for tests that
need a storage engine and another for those that do not.

4.) Make several remaining global variables SC decorations in support of (3)

5.) Replace many MONGO_INITIALIZERS that access getGlobalServiceContext with the
new constructor-actions system, which is needed for (3.)

6.) Fix up tests to use the fixtures from (3) and fix tests that silently used
different service contexts in together in a technically illegal fashion that now
breaks.

7.) Utilize (2) as necessary to simplify initialization of new ServiceContexts,
simplifying the fixtures in (3).

(cherry picked from commit d520be0814492c262515cf0a5d62a127ace70dce)

SERVER-35985 Destroy clients started in other threads.

(cherry picked from commit 9a68eb0cc65a93233b4ff5746330f9eb77de9b90)

SERVER-36258 Construct ServiceContext after mongo initializers complete.

(cherry picked from commit bfe170e49b1dc10b2badde45bc13c057a2f8ab61)

SERVER-36400 Explicitly destroy the client on exiting run() of each BackgroundJob

(cherry picked from commit b079e4713d897b5541c2804386025817ec720800)

SERVER-36351 Fix so ServiceContextMongoDTest removes the temp directory in its destructor.

(cherry picked from commit 4c16f0f336f4db77034e8aa594bbd4a5bac3f40c)

SERVER-36347 Fix parse_zone_info.py after ServiceContext refactor.

(cherry picked from commit c9d4204b6243e5eee6fe0b5e2c34d02af9ac5edb)
Branch: v4.0
https://github.com/mongodb/mongo/commit/58feaec9c55629ba253b1ff013736eb8b8e9c79d

Comment by Githook User [ 07/Aug/18 ]

Author:

{'username': 'henrikedin', 'name': 'Henrik Edin', 'email': 'henrik.edin@mongodb.com'}

Message: SERVER-36351 Fix so ServiceContextMongoDTest removes the temp directory in its destructor.
Branch: master
https://github.com/mongodb/mongo/commit/4c16f0f336f4db77034e8aa594bbd4a5bac3f40c

Generated at Thu Feb 08 04:42:50 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.