[SERVER-36351] ServiceContextMongoDTest doesn't persist TempDir correctly Created: 30/Jul/18 Updated: 29/Oct/23 Resolved: 08/Aug/18 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Internal Code |
| Affects Version/s: | None |
| Fix Version/s: | 4.0.3, 4.1.2 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Eric Milkie | Assignee: | Unassigned |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||
| Operating System: | ALL | ||||||||
| Sprint: | Platforms 2018-08-13 | ||||||||
| Participants: | |||||||||
| Description |
|
In ServiceContextMongoDTest::ServiceContextMongoDTest(), it puts a unittest::TempDir on the stack. This seems unintentional, as the code immediately removes the temporary directory when the constructor finishes.
(And I believe the test ends up littering the Windows test machines with many temp directories.) |
| Comments |
| Comment by Githook User [ 13/Sep/18 ] |
|
Author: {'name': 'Henrik Edin', 'email': 'henrik.edin@mongodb.com', 'username': 'henrikedin'}Message: This patch does several loosely related and surprisingly hard to separate things. 1.) Make the ServiceContext class final 2.) Create a mechanism, called ConstructorActions, for running methods on 3.) Introduce / improve test fixture base classes for tests, giving them fresh 4.) Make several remaining global variables SC decorations in support of (3) 5.) Replace many MONGO_INITIALIZERS that access getGlobalServiceContext with the 6.) Fix up tests to use the fixtures from (3) and fix tests that silently used 7.) Utilize (2) as necessary to simplify initialization of new ServiceContexts, (cherry picked from commit d520be0814492c262515cf0a5d62a127ace70dce)
(cherry picked from commit 9a68eb0cc65a93233b4ff5746330f9eb77de9b90)
(cherry picked from commit bfe170e49b1dc10b2badde45bc13c057a2f8ab61)
(cherry picked from commit b079e4713d897b5541c2804386025817ec720800)
(cherry picked from commit 4c16f0f336f4db77034e8aa594bbd4a5bac3f40c)
(cherry picked from commit c9d4204b6243e5eee6fe0b5e2c34d02af9ac5edb) |
| Comment by Githook User [ 07/Aug/18 ] |
|
Author: {'username': 'henrikedin', 'name': 'Henrik Edin', 'email': 'henrik.edin@mongodb.com'}Message: |