[SERVER-3639] --repair fails if mongodb.lock file exists (and has data) if journaling on (but there are no journal files) Created: 17/Aug/11 Updated: 15/Aug/12 Resolved: 01/Jun/12 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Storage |
| Affects Version/s: | 1.9.2 |
| Fix Version/s: | 2.1.2 |
| Type: | Bug | Priority: | Minor - P4 |
| Reporter: | Scott Hernandez (Inactive) | Assignee: | Mathias Stearn |
| Resolution: | Done | Votes: | 1 |
| Labels: | journal, repair | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||
| Backwards Compatibility: | Minor Change | ||||
| Operating System: | ALL | ||||
| Participants: | |||||
| Description |
|
Since journaling is now enabled by default (1.9.2+) then a repair will fail if the lock file has data from a previous run without journaling on. A repair should run even if there are no journal files when journaling is on (now default). FAILS: ************** SUCCEEDS: |
| Comments |
| Comment by auto [ 21/Jun/12 ] |
|
Author: {u'date': u'2012-06-21T09:02:28-07:00', u'email': u'samk@10gen.com', u'name': u'Sam Kleinman'}Message: minor: corrections in response to feedback on |
| Comment by auto [ 07/Jun/12 ] |
|
Author: {u'login': u'tychoish', u'name': u'Sam Kleinman', u'email': u'samk@10gen.com'}Message: |
| Comment by Mathias Stearn [ 01/Jun/12 ] |
|
See commit Message for docs changes needed. |
| Comment by auto [ 01/Jun/12 ] |
|
Author: {u'login': u'RedBeard0531', u'name': u'Mathias Stearn', u'email': u'mathias@10gen.com'}Message: --repair should disable journaling |
| Comment by Mathias Stearn [ 17/Aug/11 ] |
|
I think current behavior is correct (although the message might need some work). There are two cases that could cause this: 1) Crashed with --nojournal (or 1.8) and tried to repair with journaling enabled 2) journal dir is on a different device that isn't mounted. Both are user errors. 2 could cause massive uncorrectable corruption. With 1, there is no good reason to use journalling for the repair and it would just slow it down. |