[SERVER-3644] cmdLine.journalCommitInterval checks are inconsistent Created: 18/Aug/11  Updated: 06/Dec/22  Resolved: 15/Nov/16

Status: Closed
Project: Core Server
Component/s: Storage
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Trivial - P5
Reporter: Scott Hernandez (Inactive) Assignee: Backlog - Storage Execution Team
Resolution: Done Votes: 0
Labels: journal, neweng
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Duplicate
is duplicated by DOCS-1446 discrepancy in the documentation for ... Closed
is duplicated by SERVER-9479 journalCommitInterval has different a... Closed
is duplicated by SERVER-17500 JournalCommitInterval validation does... Closed
Related
Assigned Teams:
Storage Execution
Operating System: ALL
Participants:

 Description   

db/db.cpp:744
if( cmdLine.journalCommitInterval <= 1 || cmdLine.journalCommitInterval > 300 ) {
out() << "--journalCommitInterval out of allowed range (0-300ms)" << endl;

db/db_commands_generic.cpp:148
int x = (int) cmdObj["journalCommitInterval"].Number();
assert( x > 1 && x < 500 );
cmdLine.journalCommitInterval = x;
log() << "setParameter journalCommitInterval=" << x << endl;



 Comments   
Comment by Eric Milkie [ 15/Nov/16 ]

Code was refactored and the new messaging is correct.

Comment by Scott Hernandez (Inactive) [ 08/Mar/13 ]

Still off, see db/commands/parameter.cpp:100 (cmdSet.run)

             if( cmdObj.hasElement("journalCommitInterval") ) {
                if( !cmdLine.dur ) {
                    errmsg = "journaling is off";
                    return false;
                }
                int x = (int) cmdObj["journalCommitInterval"].Number();
                verify( x > 1 && x < 500 );
                cmdLine.journalCommitInterval = x;
                log() << "setParameter journalCommitInterval=" << x << endl;
                s++;

Comment by Andrew Emil (Inactive) [ 08/Mar/13 ]

Seems to be consistent now, but the message is not true (0 is not an accepted value)

Generated at Thu Feb 08 03:03:38 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.