[SERVER-36467] continuous stepdown overrides should maintain parameters Created: 06/Aug/18  Updated: 29/Oct/23  Resolved: 10/Aug/18

Status: Closed
Project: Core Server
Component/s: Testing Infrastructure
Affects Version/s: None
Fix Version/s: 4.1.2, 4.0.18

Type: Bug Priority: Major - P3
Reporter: David Bradford (Inactive) Assignee: David Bradford (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Related
Backwards Compatibility: Fully Compatible
Operating System: ALL
Backport Requested:
v4.0, v3.6
Sprint: TIG 2018-08-27, TIG 2018-08-13
Participants:
Linked BF Score: 15

 Description   

The continuous_stepdown suites overrides some of the ReplSetTest functions in continuous_stepdown.js. They do not, however, maintain all the parameters that are passed to the original functions. Which means the behavior is not maintained. For example, startSet takes a 'restart' parameter that is missing from the overridden version. The overridden version should maintain all the parameters of the original functions.

The three functions being overridden are:

  • startSet
  • stopSet (It looks like this uses the parameters variable to maintain the parameter list).
  • awaitLastOpCommitted

It would be great to actually capture all the original parameters or enforce that new parameters must be added to the overridden functions so that if new parameters are added to the original functions in the future, we can be sure to add them to the overridden versions as well.



 Comments   
Comment by Githook User [ 13/Mar/20 ]

Author:

{'username': 'dbradf', 'name': 'David Bradford', 'email': 'david.bradford@mongodb.com'}

Message: SERVER-36467: pass arguments to original function when overriding ReplSetTest functions

(cherry picked from commit 3e66a68ffb5c481661b4fe1fb426a746c50951a9)
Branch: v4.0
https://github.com/mongodb/mongo/commit/ff506e4e333a1ff03ea30ea2ba9cb40ba87a47d4

Comment by Githook User [ 10/Aug/18 ]

Author:

{'name': 'David Bradford', 'email': 'david.bradford@mongodb.com', 'username': 'dbradf'}

Message: SERVER-36467: pass arguments to original function when overriding ReplSetTest functions
Branch: master
https://github.com/mongodb/mongo/commit/3e66a68ffb5c481661b4fe1fb426a746c50951a9

Generated at Thu Feb 08 04:43:11 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.