[SERVER-3650] ReplicaSet rollback should use slaveOk Created: 18/Aug/11  Updated: 11/Jul/16  Resolved: 07/Sep/11

Status: Closed
Project: Core Server
Component/s: Replication
Affects Version/s: None
Fix Version/s: 2.0.0-rc2

Type: Bug Priority: Major - P3
Reporter: Mathias Stearn Assignee: Mathias Stearn
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
is related to SERVER-3772 Re-enable rollback4.js Closed
Operating System: ALL
Participants:

 Description   

Currently we are already querying secondaries but it will fail and get stuck in ROLLBACK state:

Th│Thu Aug 18 17:30:55 [rsSync] replSet syncing to: redbeard:10003
Th│Thu Aug 18 17:30:55 [rsSync] replSet our last op time written: Aug 18 17:26:03:1
Th│Thu Aug 18 17:30:55 [rsSync] replset source's GTE: Aug 18 17:28:08:1
Th│Thu Aug 18 17:30:55 [rsSync] replSet rollback 0
Th│Thu Aug 18 17:30:55 [rsSync] replSet ROLLBACK
Th│Thu Aug 18 17:30:55 [rsSync] replSet rollback 1
Th│Thu Aug 18 17:30:55 [rsSync] replSet rollback 2 FindCommonPoint
Th Thu Aug 18 17:30:55 [rsSync] replSet info rollback our last optime: Aug 18 17:26:03:1
03 Thu Aug 18 17:30:55 [rsSync] replSet info rollback their last optime: Aug 18 17:29:59:1
Th Thu Aug 18 17:30:55 [rsSync] replSet info rollback diff in end of log times: -236 seconds
Th Thu Aug 18 17:30:55 [rsSync] replSet rollback found matching events at Aug 18 17:20:12:1
Th Thu Aug 18 17:30:55 [rsSync] replSet rollback findcommonpoint scanned : 5
Th Thu Aug 18 17:30:55 [rsSync] replSet replSet rollback 3 fixup
Th Thu Aug 18 17:30:55 [rsSync] replSet rollback re-get objects: 13106 nextSafe():

{ $err: "not master and slaveok=false", code: 13435 }

Th Thu Aug 18 17:30:55 [rsSync] rollback couldn't re-get ns:test.foo _id:_id: 1.0 1/1
Th Thu Aug 18 17:30:55 [rsSync] replSet syncThread: 13106 nextSafe():

{ $err: "not master and slaveok=false", code: 13435 }

Th Thu Aug 18 17:31:06 [rsSync] replSet syncing to: redbeard:10003
Th Thu Aug 18 17:31:06 [rsSync] replSet our last op time written: Aug 18 17:26:03:1
Th Thu Aug 18 17:31:06 [rsSync] replset source's GTE: Aug 18 17:28:08:1
Th Thu Aug 18 17:31:06 [rsSync] replSet rollback 0
04 Thu Aug 18 17:31:06 [rsSync] replSet rollback 1
Th Thu Aug 18 17:31:06 [rsSync] replSet rollback 2 FindCommonPoint
Th Thu Aug 18 17:31:06 [rsSync] replSet rollback 2 error findcommonpoint waiting a while before trying again
Th Thu Aug 18 17:31:17 [rsSync] replSet syncing to: redbeard:10003
Th Thu Aug 18 17:31:17 [rsSync] replSet our last op time written: Aug 18 17:26:03:1
Th Thu Aug 18 17:31:17 [rsSync] replset source's GTE: Aug 18 17:28:08:1
Th Thu Aug 18 17:31:17 [rsSync] replSet rollback 0
Th Thu Aug 18 17:31:17 [rsSync] replSet rollback 1
Th Thu Aug 18 17:31:17 [rsSync] replSet rollback 2 FindCommonPoint
Th Thu Aug 18 17:31:17 [rsSync] replSet rollback 2 error findcommonpoint waiting a while before trying again
Th Thu Aug 18 17:31:20 [initandlisten] connection accepted from 127.0.0.1:49341 #8
Th Thu Aug 18 17:31:20 [initandlisten] warning: Stack size set to 768KB. We suggest 1MB
05 Thu Aug 18 17:31:28 [rsSync] replSet syncing to: redbeard:10003
Th Thu Aug 18 17:31:28 [rsSync] replSet our last op time written: Aug 18 17:26:03:1
Th Thu Aug 18 17:31:28 [rsSync] replset source's GTE: Aug 18 17:28:08:1
Th Thu Aug 18 17:31:28 [rsSync] replSet rollback 0
Th Thu Aug 18 17:31:28 [rsSync] replSet rollback 1
Th Thu Aug 18 17:31:28 [rsSync] replSet rollback 2 FindCommonPoint
Th Thu Aug 18 17:31:28 [rsSync] replSet rollback 2 error findcommonpoint waiting a while before trying again
Th Thu Aug 18 17:31:39 [rsSync] replSet syncing to: redbeard:10003
Th Thu Aug 18 17:31:39 [rsSync] replSet our last op time written: Aug 18 17:26:03:1

and so on...

I'll try to work up a jstest



 Comments   
Comment by auto [ 07/Sep/11 ]

Author:

{u'login': u'RedBeard0531', u'name': u'Mathias Stearn', u'email': u'mathias@10gen.com'}

Message: Disable test for now. Looks like a timing issue. SERVER-3650 SERVER-3772
Branch: master
https://github.com/mongodb/mongo/commit/afa19a36958852526ed2c74717f505d137575bd2

Comment by auto [ 07/Sep/11 ]

Author:

{u'login': u'RedBeard0531', u'name': u'Mathias Stearn', u'email': u'mathias@10gen.com'}

Message: Queries for rollback objects need SlaveOk bit SERVER-3650
Branch: master
https://github.com/mongodb/mongo/commit/6362013e418bd0ed854ef6d623e07b44ba2f6b3c

Comment by auto [ 22/Aug/11 ]

Author:

{u'login': u'RedBeard0531', u'name': u'Mathias Stearn', u'email': u'mathias@10gen.com'}

Message: Add disabled test for SERVER-3650
Branch: master
https://github.com/mongodb/mongo/commit/68085eb00e6d7395cc3deeb9dcb3a027f87ecf89

Generated at Thu Feb 08 03:03:39 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.