[SERVER-36573] Coverity analysis defect 104957: Copy without assign Created: 10/Aug/18  Updated: 29/Oct/23  Resolved: 20/Aug/18

Status: Closed
Project: Core Server
Component/s: Storage
Affects Version/s: None
Fix Version/s: 4.1.3

Type: Bug Priority: Major - P3
Reporter: Coverity Collector User Assignee: Dewal Gupta
Resolution: Fixed Votes: 0
Labels: coverity, nyc
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Operating System: ALL
Sprint: Storage NYC 2018-08-13, Storage NYC 2018-08-27
Participants:

 Description   

Class has user-written copy constructor but no user-written assignment operator

Defect 104957 (STATIC_C)
Checker COPY_WITHOUT_ASSIGN (subcategory none)
File: /src/mongo/db/storage/biggie/store.h
Parse Warning (no function name available)
/src/mongo/db/storage/biggie/store.h, line: 208
Class "mongo::biggie::RadixStore<std::_cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >::reverse_radix_iterator<std::pair<std::cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > const *, std::pair<std::cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > const &>" has a user-written copy constructor "mongo::biggie::RadixStore<std::cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >::reverse_radix_iterator<std::pair<std::cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > const *, std::pair<std::cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > const &>::reverse_radix_iterator(mongo::biggie::RadixStore<std::cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >::reverse_radix_iterator<std::pair<std::cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > const *, std::pair<std::cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::_cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > const &> const &)" but no corresponding user-written assignment operator.

        class reverse_radix_iterator {

/src/mongo/db/storage/biggie/store.h, line: 246
User-written copy constructor.

            reverse_radix_iterator(const reverse_radix_iterator& other)



 Comments   
Comment by Githook User [ 20/Aug/18 ]

Author:

{'name': 'Dewal Gupta', 'email': 'dewal.gupta@10gen.com', 'username': 'dewalg'}

Message: SERVER-36573 remove unnecessary operators, constructors for Biggie SE
Branch: master
https://github.com/mongodb/mongo/commit/35931cc44fd57ab0a9d29c5a969d12d3765ba52f

Comment by Eric Milkie [ 10/Aug/18 ]

This problem was also flagged for the radix_iterator and RadixStore classes.

Generated at Thu Feb 08 04:43:31 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.