[SERVER-36634] Change FCV check to check for CommandNotFound in _shardsvrShardCollection and write to config after creating collections on non-primary shards Created: 14/Aug/18  Updated: 29/Oct/23  Resolved: 13/Sep/18

Status: Closed
Project: Core Server
Component/s: Sharding
Affects Version/s: None
Fix Version/s: 4.0.3, 4.1.3

Type: Task Priority: Major - P3
Reporter: Janna Golden Assignee: Janna Golden
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Depends
Backwards Compatibility: Fully Compatible
Backport Requested:
v4.0
Sprint: Sharding 2018-08-27, Sharding 2018-09-10, Sharding 2018-09-24
Participants:
Linked BF Score: 26

 Description   

We are backporting the changes to shardCollection so should remove the FCV check in 4.2. Instead we should check if the command failed with CommandNotFound, and if so run the old logic. We should also move writing to the config and catalog to after we send _cloneCollectionOptionsFromPrimaryShard to the other non-primary shards so that if any of them fail, we can retry the command running the old path.



 Comments   
Comment by Githook User [ 13/Sep/18 ]

Author:

{'name': 'jannaerin', 'email': 'golden.janna@gmail.com', 'username': 'jannaerin'}

Message: SERVER-36634 Change FCV check to check for CommandNotFound in configsvrShardCollection and write to config after creating collections on non-primary shards

(cherry picked from commit db3d9907d3934b34395a5b6f2f358994b9da5d99)
Branch: v4.0
https://github.com/mongodb/mongo/commit/6f363704dbcbf0dffb3d71138f7df36f9b1654c4

Comment by Githook User [ 13/Sep/18 ]

Author:

{'name': 'jannaerin', 'email': 'golden.janna@gmail.com', 'username': 'jannaerin'}

Message: SERVER-36634 Change FCV check to check for CommandNotFound in configsvrShardCollection and write to config after creating collections on non-primary shards
Branch: master
https://github.com/mongodb/mongo/commit/db3d9907d3934b34395a5b6f2f358994b9da5d99

Comment by Janna Golden [ 15/Aug/18 ]

Sorry - it's the latter, I meant to explain that in the description but it wasn't very clear.

Comment by Kaloian Manassiev [ 15/Aug/18 ]

janna.golden, did you mean to just remove the FCV check or to instead start relying on a CommandNotFound being returned from the shard as a hint to back-off to the legacy shard collection logic? I think it is the latter, but wanted to make sure.

Comment by Esha Maharishi (Inactive) [ 14/Aug/18 ]

Hmm. I don't think it's safe to remove the check, since a user can be running a mixed-version cluster with a version of 4.0 that doesn't have the backport.

Generated at Thu Feb 08 04:43:41 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.