[SERVER-36725] periodic_runner_impl_test should manually call tearDown Created: 17/Aug/18 Updated: 29/Oct/23 Resolved: 28/Aug/18 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Internal Code |
| Affects Version/s: | None |
| Fix Version/s: | 3.6.8, 4.0.3, 4.1.3 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Mira Carey | Assignee: | Mira Carey |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||
| Operating System: | ALL | ||||||||
| Backport Requested: |
v4.0, v3.6
|
||||||||
| Sprint: | Platforms 2018-08-27, Platforms 2018-09-10 | ||||||||
| Participants: | |||||||||
| Linked BF Score: | 22 | ||||||||
| Description |
|
The periodic_runner_impl_test holds references to stack allocated condvars in every one of its tests. All of them have a chance to data race (destruction and job invocation, or the end of job invocation). Manually calling tearDown in all cases fixes those races |
| Comments |
| Comment by Githook User [ 06/Sep/18 ] |
|
Author: {'name': 'Jason Carey', 'email': 'jcarey@argv.me', 'username': 'hanumantmk'}Message: The periodic_runner_impl_test holds references to stack allocated Manually calling tearDown in all cases fixes those races (cherry picked from commit 5321f4b168cb70fc03711f42b9f58c34935ff101) |
| Comment by Githook User [ 05/Sep/18 ] |
|
Author: {'name': 'Jason Carey', 'email': 'jcarey@argv.me', 'username': 'hanumantmk'}Message: The periodic_runner_impl_test holds references to stack allocated Manually calling tearDown in all cases fixes those races (cherry picked from commit 5321f4b168cb70fc03711f42b9f58c34935ff101) |
| Comment by Githook User [ 28/Aug/18 ] |
|
Author: {'name': 'Jason Carey', 'email': 'jcarey@argv.me', 'username': 'hanumantmk'}Message: The periodic_runner_impl_test holds references to stack allocated Manually calling tearDown in all cases fixes those races |