[SERVER-36728] Do not ignore all abortTransaction errors in tests Created: 17/Aug/18  Updated: 29/Oct/23  Resolved: 30/Oct/18

Status: Closed
Project: Core Server
Component/s: Replication, Testing Infrastructure
Affects Version/s: None
Fix Version/s: 4.1.5

Type: Improvement Priority: Major - P3
Reporter: Judah Schvimer Assignee: Pavithra Vetriselvan
Resolution: Fixed Votes: 0
Labels: prepare_testing
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Sprint: Repl 2018-09-10, Repl 2018-09-24, Repl 2018-10-08, Repl 2018-10-22, Repl 2018-11-05
Participants:

 Description   

We currently ignore all abortTransaction errors in our tests, when in reality NoSuchTransaction is the only one we really want to ignore. At the very least we should log any other error we receive, and likely it will be helpful and safe to only ignore NoSuchTransaction (though trying it out may show this isn't feasible). We can limit this to in our tests to conform to the driver spec.



 Comments   
Comment by Githook User [ 30/Oct/18 ]

Author:

{'name': 'Pavi Vetriselvan', 'email': 'pvselvan@umich.edu', 'username': 'pvselvan'}

Message: SERVER-36728 Don't ignore errors when aborting a transaction in tests
Branch: master
https://github.com/mongodb/mongo/commit/6ead45d2b861f395c7c9e21606b10adbae67382d

Comment by Tess Avitabile (Inactive) [ 17/Aug/18 ]

Most jstests actually use abortTransaction_forTesting(), which does not ignore errors. However, auto_retry_transaction.js in the concurrency suite uses abortTransaction(), which ignores errors.

Generated at Thu Feb 08 04:43:55 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.