[SERVER-36749] Remove race in Service Executor Adaptive shutdown Created: 17/Aug/18  Updated: 29/Oct/23  Resolved: 06/Sep/18

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 4.0.3, 4.1.3

Type: Bug Priority: Minor - P4
Reporter: Benjamin Caimano (Inactive) Assignee: Benjamin Caimano (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Depends
Backwards Compatibility: Fully Compatible
Operating System: ALL
Backport Requested:
v4.0
Sprint: Platforms 2018-08-27, Platforms 2018-09-10
Participants:
Linked BF Score: 4

 Description   

Gotta check for existing condition before unlocking in deathCondition.



 Comments   
Comment by Githook User [ 07/Sep/18 ]

Author:

{'name': 'Ben Caimano', 'email': 'ben.caimano@10gen.com'}

Message: SERVER-36749 Remove race in Service Executor Adaptive test

Main commit

(cherry picked from commit a081f728209f6a5d39353835c1a711a2ebf93563)

Removing illegal virtual constexpr

(cherry picked from commit 26342af7491525e893b0ac106fb8a6e101daf33e)
Branch: v4.0
https://github.com/mongodb/mongo/commit/6713772287ca0e9cd6668b031916eef7472dd0b8

Comment by Githook User [ 06/Sep/18 ]

Author:

{'name': 'Ben Caimano', 'email': 'ben.caimano@10gen.com'}

Message: SERVER-36749 Remove race in Service Executor Adaptive test

Removing illegal virtual constexpr
Branch: master
https://github.com/mongodb/mongo/commit/26342af7491525e893b0ac106fb8a6e101daf33e

Comment by Githook User [ 06/Sep/18 ]

Author:

{'name': 'Ben Caimano', 'email': 'ben.caimano@10gen.com'}

Message: SERVER-36749 Remove race in Service Executor Adaptive test
Branch: master
https://github.com/mongodb/mongo/commit/a081f728209f6a5d39353835c1a711a2ebf93563

Comment by Benjamin Caimano (Inactive) [ 30/Aug/18 ]

Sadly, as adam.martin@mongodb.com correctly noticed, I was barking up the wrong tree around the same wait point. I'm waiting for him to have time to LGTM or criticize my alternative solution.

Comment by Gregory McKeon (Inactive) [ 30/Aug/18 ]

ben.caimano can this be pushed?

Generated at Thu Feb 08 04:43:59 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.