[SERVER-36889] Explore removing the index catalog SCons shims Created: 27/Aug/18  Updated: 29/Oct/23  Resolved: 12/Oct/18

Status: Closed
Project: Core Server
Component/s: Storage
Affects Version/s: None
Fix Version/s: 4.1.5

Type: Improvement Priority: Major - P3
Reporter: Dianna Hohensee (Inactive) Assignee: Benety Goh
Resolution: Fixed Votes: 0
Labels: nyc
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
related to SERVER-29908 Libraries db/s/sharding and db/query/... Closed
Backwards Compatibility: Fully Compatible
Sprint: Storage NYC 2018-10-08, Storage NYC 2018-10-22
Participants:

 Description   

With the completion of SERVER-29908, removing a circular dependency in our SCons libraries, we should revisit whether it is possible to get rid of the SCons shims in many index catalog files – like here, here and here!

This would make working with the index code much easier. There are also similar shims elsewhere in the catalog, but we have a lot of v4.2 work around indexes coming up.



 Comments   
Comment by Githook User [ 12/Oct/18 ]

Author:

{'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}

Message: SERVER-36889 unshim MultiIndexBlock
Branch: master
https://github.com/mongodb/mongo/commit/65eced031a2c8d8b1c5e5815881466b8fbb3bc01

Comment by Githook User [ 12/Oct/18 ]

Author:

{'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}

Message: SERVER-36889 unshim IndexCatalogEntry
Branch: master
https://github.com/mongodb/mongo/commit/849c85561e065598813d6a702ce132f494380eed

Comment by Githook User [ 12/Oct/18 ]

Author:

{'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}

Message: SERVER-36889 unshim IndexCatalog
Branch: master
https://github.com/mongodb/mongo/commit/3810ea3cec6bcba7c0e62ce0170ea34b31046dcf

Comment by Githook User [ 11/Oct/18 ]

Author:

{'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}

Message: SERVER-36889 split IndexAccessMethod into interface and abstract implementation
Branch: master
https://github.com/mongodb/mongo/commit/2596d96f4a826777d7210b94d46a5b36aebfd15b

Comment by Eric Milkie [ 02/Oct/18 ]

In addition to removing the index catalog shims, this would be a good opportunity to rename index_create.* to be multi_index_block.*, to match our current style.

Generated at Thu Feb 08 04:44:22 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.