[SERVER-36986] list_local_sessions.js expects non-existent session to exist when running concurrently with LogicalSessionsCache refresh Created: 04/Sep/18  Updated: 29/Oct/23  Resolved: 25/Sep/18

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: 4.1.2
Fix Version/s: 3.6.9, 4.0.4, 4.1.4

Type: Bug Priority: Major - P3
Reporter: Blake Oler Assignee: Blake Oler
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Backwards Compatibility: Fully Compatible
Operating System: ALL
Backport Requested:
v4.0, v3.6
Sprint: Sharding 2018-09-24
Participants:

 Description   

Investigation

When running a passthrough suite with the logical session cache refresh set to 100ms, it can cause failures in list_local_sessions.js. The test expects a session to exist, but it's likely been reaped by the time that assert.expect is run.

Proposed Fix

After some thought, it seems the best idea to blacklist list_sessions.js and list_all_sessions from the logical session cache suites. These tests rely on the command `refreshLogicalSessionCacheNow`, which is supposed to refresh the cache in a deterministic fashion. Running these tests with the background refresh thread on interferes with the deterministic nature of the tests, because refresh operations can happen when they're not supposed to.

Since both these tests are in jsCore, I'm not worried about losing test coverage.



 Comments   
Comment by Githook User [ 25/Sep/18 ]

Author:

{'name': 'Blake Oler', 'email': 'blake.oler@mongodb.com', 'username': 'BlakeIsBlake'}

Message: SERVER-36986 Add list_all_local_sessions.js to LogicalSessionCache refresh blacklists
Branch: master
https://github.com/mongodb/mongo/commit/18149f4b621b5de6a9d977fac5cc96fb028662a7

Comment by Blake Oler [ 24/Sep/18 ]

Re-opening because we need to add list_all_local_sessions.js to the blacklists.

Comment by Blake Oler [ 21/Sep/18 ]

Author:

{'name': 'Blake Oler', 'email': 'blake.oler@mongodb.com', 'username': 'BlakeIsBlake'}

Message: SERVER-36850 Add a replica set passthrough suite to detect errors in the logical session cache
SERVER-36986 Blacklist tests not meant to run concurrently with a background logical session cache refresh thread
SERVER-37187 Temporarily disable oplog validation in the validateCollections hook in logical session cache suites
Branch: master
https://github.com/mongodb/mongo/commit/1828360710a6f44da6e95d1fe4760412ad65c848

Comment by Githook User [ 21/Sep/18 ]

Author:

{'name': 'Blake Oler', 'email': 'blake.oler@mongodb.com', 'username': 'BlakeIsBlake'}

Message: SERVER-36850 Add a replica set passthrough suite to detect errors in the logical session cache
SERVER-36986 Blacklist tests not meant to run concurrently with a background logical session cache refresh thread
SERVER-37187 Temporarily disable oplog validation in the validateCollections hook in logical session cache suites
Branch: master
https://github.com/mongodb/mongo/commit/1828360710a6f44da6e95d1fe4760412ad65c848

Comment by Misha Tyulenev [ 20/Sep/18 ]

ack

Comment by Blake Oler [ 18/Sep/18 ]

misha.tyulenev proposed fix for you to ack

Generated at Thu Feb 08 04:44:39 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.