[SERVER-37001] Add 'idleCursors' flag to $currentOp and report stats we already have Created: 05/Sep/18 Updated: 29/Oct/23 Resolved: 14/Sep/18 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Diagnostics |
| Affects Version/s: | None |
| Fix Version/s: | 4.1.4 |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Charlie Swanson | Assignee: | Ted Tuckman |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||
| Sprint: | Query 2018-09-24 | ||||||||||||
| Participants: | |||||||||||||
| Description |
|
In this ticket, we will make the flag gather a list of idle cursors, determined solely by whether or not they are pinned. This is similar to what is done in the Proof of Concept except it will also add fields to GenericCursor which are already present on both ClientCursor and ClusterClientCursor It also should not bother to include any cursor object in the 'inprog' ops for any getmore ops. This will happen later. This was attempted in the POC but we decided to do it a different way, namely by tracking a GenericCursor on the CurOp object during the getMore command. This covers both mongos and mongod. Any fields that exist exclusively on mongod or exclusively on mongos should be excluded in this ticket. |
| Comments |
| Comment by Ted Tuckman [ 31/Oct/18 ] |
|
I don't have a strong opinion, whichever you guys decide/ think is best I'm happy to go along with. |
| Comment by Charlie Swanson [ 31/Oct/18 ] |
|
blake.oler you mean withPinnedCursor? I don't think there's an 'official' way to do this and don't have a great answer for you. Perhaps just mention Ted's name in the commit message? ted.tuckman is that good enough for you? Or perhaps Ted can sign-off on the backport, like we do for external contributors, e.g. this commit. |
| Comment by Blake Oler [ 31/Oct/18 ] |
|
Would like to backport ted.tuckman's Javascript pinned cursor helper to 4.0 and 3.6. What's the official process to do this and still give proper attribution? |
| Comment by Githook User [ 14/Sep/18 ] |
|
Author: {'name': 'Ted Tuckman', 'email': 'ted.tuckman@mongodb.com', 'username': 'TedTuckman'}Message: |
| Comment by Ted Tuckman [ 06/Sep/18 ] |
|
After discussion we decided not to add fields for the mongos version at this point beyond what the POC implemented. The rest of the fields will be added when the GenericCursor is added to CurOp |