[SERVER-37047] Move assertions out of testshard1.js that depend on data distribution Created: 07/Sep/18  Updated: 29/Oct/23  Resolved: 04/Mar/19

Status: Closed
Project: Core Server
Component/s: Querying
Affects Version/s: None
Fix Version/s: 4.1.9

Type: Bug Priority: Major - P3
Reporter: Matthew Saltz (Inactive) Assignee: Charlie Swanson
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
Related
is related to SERVER-38976 aggregation/testshard1.js fails with ... Closed
Backwards Compatibility: Fully Compatible
Operating System: ALL
Participants:
Linked BF Score: 5

 Description   

The balancer in testshard1.js is turned on to mimic a client enviroment where aggregations are issued concurrently with balancing. More recently the balancer was changed in a way that sometimes left the cluster with all chunks on one shard, which exposed some assertions in this test that depend on a particular data distribution. Such assertions are not appropriate for this test and should instead construct their own cluster which matches their assumptions.



 Comments   
Comment by Githook User [ 04/Mar/19 ]

Author:

{'name': 'Charlie Swanson', 'email': 'charlie.swanson@mongodb.com', 'username': 'cswanson310'}

Message: SERVER-37047 Split up testshard1.js

Splits some assertions about explain out of the test to fix some build
failures. Also renames the test and moves it to the sharding suite and
cleans up some old TODOs and makeshift passthroughs.
Branch: master
https://github.com/mongodb/mongo/commit/56efcffbcba956aa24518c71d100ecffee965058

Comment by Charlie Swanson [ 01/Mar/19 ]

Since this is blocking a BF I did not close it, but rather adjusted the goal. I'll pick this up and do it as part of BF friday today.

Comment by Charlie Swanson [ 10/Sep/18 ]

I think instead we should write the test to not rely on any particular distribution of data. In particular, any assertions that rely on data being spread across multiple shards should be re-written or moved to another test.

Generated at Thu Feb 08 04:44:49 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.