[SERVER-37096] Allow _runMongoProgram to run non-exe files on Windows Created: 12/Sep/18  Updated: 29/Oct/23  Resolved: 13/Dec/18

Status: Closed
Project: Core Server
Component/s: Shell
Affects Version/s: None
Fix Version/s: 4.1.7

Type: Improvement Priority: Major - P3
Reporter: Benjamin Caimano (Inactive) Assignee: Jonathan Ma
Resolution: Fixed Votes: 0
Labels: neweng
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
Backwards Compatibility: Fully Compatible
Sprint: Service Arch 2018-12-17
Participants:
Linked BF Score: 50

 Description   

As of now, we change all file extensions in _runMongoProgram to ".exe" on Windows. This is used to target "mongo" and hit "mongo.exe" for instance. I believe that we should simply add an extension if there isn't already one. At time of writing, this will allow us to call batch, python, and node scripts during resmoke runs.



 Comments   
Comment by Githook User [ 13/Dec/18 ]

Author:

{'username': 'thejonathanma', 'email': 'thejonathanma@gmail.com', 'name': 'Jonathan'}

Message: SERVER-37096 Fix to allow for multiversion naming in executable files
Branch: master
https://github.com/mongodb/mongo/commit/ed1007a8e277c3ffa3808605c53675d31a380dbe

Comment by Githook User [ 10/Dec/18 ]

Author:

{'name': 'Jonathan', 'email': 'thejonathanma@gmail.com', 'username': 'thejonathanma'}

Message: SERVER-37096 shell now checks for missing extension before appending exe
Branch: master
https://github.com/mongodb/mongo/commit/8d91afc4ba367a300c819202abdf905e4f3d6646

Comment by Max Hirschhorn [ 12/Sep/18 ]

I believe that we should simply add an extension if there isn't already one.

I agree. acm made a similar change to resmoke.py back in b38e019 as part of SERVER-19677.

Generated at Thu Feb 08 04:44:57 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.