[SERVER-37126] Invoke runSafely for all external implscope methods Created: 13/Sep/18  Updated: 29/Oct/23  Resolved: 17/Sep/18

Status: Closed
Project: Core Server
Component/s: JavaScript
Affects Version/s: None
Fix Version/s: 3.6.9, 4.0.4, 4.1.4

Type: New Feature Priority: Major - P3
Reporter: Mira Carey Assignee: Mira Carey
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Depends
is depended on by SERVER-35154 Exceptions that escape a ScopedThread... Closed
Duplicate
is duplicated by SERVER-32565 Stepdown suites should tolerate js en... Closed
Related
related to SERVER-32565 Stepdown suites should tolerate js en... Closed
Backwards Compatibility: Fully Compatible
Backport Requested:
v4.0, v3.6
Sprint: Platforms 2018-09-24
Participants:
Linked BF Score: 16

 Description   

Implscope provides a runSafely helper which wraps method calls and ensures that interruptions override other errors (amongst other features)

We should extend that to all methods that are callable.

_createFunction in particular is callable publically, which allows "method could not be called" to leak past interruption when parsing javascript for $where



 Comments   
Comment by Githook User [ 09/Oct/18 ]

Author:

{'name': 'Jason Carey', 'email': 'jcarey@argv.me', 'username': 'hanumantmk'}

Message: SERVER-37126 Always _runSafely in implscope

Extends _runSafely use to all public methods on implscope

(cherry picked from commit 1faa184e835a7a628631064af08389471d64ed0f)
Branch: v4.0
https://github.com/mongodb/mongo/commit/6568a3f56fdcc3ac7c8db73252ef214af64128a6

Comment by Githook User [ 28/Sep/18 ]

Author:

{'name': 'Jason Carey', 'email': 'jcarey@argv.me', 'username': 'hanumantmk'}

Message: SERVER-37126 Always _runSafely in implscope

Extends _runSafely use to all public methods on implscope

(cherry picked from commit 1faa184e835a7a628631064af08389471d64ed0f)
Branch: v3.6
https://github.com/mongodb/mongo/commit/551a868c6cd7c11c2582b8e0ae1360f77adfc721

Comment by Githook User [ 17/Sep/18 ]

Author:

{'name': 'Jason Carey', 'email': 'jcarey@argv.me', 'username': 'hanumantmk'}

Message: SERVER-37126 Always _runSafely in implscope

Extends _runSafely use to all public methods on implscope
Branch: master
https://github.com/mongodb/mongo/commit/1faa184e835a7a628631064af08389471d64ed0f

Generated at Thu Feb 08 04:45:03 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.