[SERVER-37126] Invoke runSafely for all external implscope methods Created: 13/Sep/18 Updated: 29/Oct/23 Resolved: 17/Sep/18 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | JavaScript |
| Affects Version/s: | None |
| Fix Version/s: | 3.6.9, 4.0.4, 4.1.4 |
| Type: | New Feature | Priority: | Major - P3 |
| Reporter: | Mira Carey | Assignee: | Mira Carey |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||||||||||||||||||
| Backport Requested: |
v4.0, v3.6
|
||||||||||||||||||||||||||||
| Sprint: | Platforms 2018-09-24 | ||||||||||||||||||||||||||||
| Participants: | |||||||||||||||||||||||||||||
| Linked BF Score: | 16 | ||||||||||||||||||||||||||||
| Description |
|
Implscope provides a runSafely helper which wraps method calls and ensures that interruptions override other errors (amongst other features) We should extend that to all methods that are callable. _createFunction in particular is callable publically, which allows "method could not be called" to leak past interruption when parsing javascript for $where |
| Comments |
| Comment by Githook User [ 09/Oct/18 ] |
|
Author: {'name': 'Jason Carey', 'email': 'jcarey@argv.me', 'username': 'hanumantmk'}Message: Extends _runSafely use to all public methods on implscope (cherry picked from commit 1faa184e835a7a628631064af08389471d64ed0f) |
| Comment by Githook User [ 28/Sep/18 ] |
|
Author: {'name': 'Jason Carey', 'email': 'jcarey@argv.me', 'username': 'hanumantmk'}Message: Extends _runSafely use to all public methods on implscope (cherry picked from commit 1faa184e835a7a628631064af08389471d64ed0f) |
| Comment by Githook User [ 17/Sep/18 ] |
|
Author: {'name': 'Jason Carey', 'email': 'jcarey@argv.me', 'username': 'hanumantmk'}Message: Extends _runSafely use to all public methods on implscope |