[SERVER-37131] Make OpObserver::onTransactionPrepare accept buffered statements Created: 13/Sep/18 Updated: 06/Dec/22 Resolved: 17/May/19 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Replication |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Siyuan Zhou | Assignee: | Backlog - Replication Team |
| Resolution: | Done | Votes: | 0 |
| Labels: | prepare_optional | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Assigned Teams: |
Replication
|
| Participants: |
| Description |
|
Currently, onTransactionPrepare() ends the transaction, cleans up the buffered statements and writes them down to the oplog. However, an observer should "observe" not "participate" the operation, so the caller should end the transaction, clean up the buffered statements and pass them into the observer. |
| Comments |
| Comment by Siyuan Zhou [ 24/Sep/18 ] |
|
See if we can get rid of transitionToPreparedforTest() in tests after we move transaction participant's logic out of OpObserver. |