[SERVER-37168] IDL: Add a method for specifying integer limits Created: 17/Sep/18 Updated: 29/Oct/23 Resolved: 05/Oct/18 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | IDL |
| Affects Version/s: | None |
| Fix Version/s: | 4.1.4 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Nicholas Zolnierz | Assignee: | Sara Golemon |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||
| Backwards Compatibility: | Fully Compatible | ||||
| Sprint: | Security 2018-10-08 | ||||
| Participants: | |||||
| Linked BF Score: | 0 | ||||
| Description |
|
For the $exchange aggregation stage, there are options that directly control the number and size of buffers that the stage will allocate and fill. It would be awesome if we could specify the limits (at least for integers) in the IDL itself instead of adding assertions in the cpp. |
| Comments |
| Comment by Githook User [ 08/Oct/18 ] | |||
|
Author: {'name': 'Sara Golemon', 'email': 'sara.golemon@mongodb.com', 'username': 'sgolemon'}Message: | |||
| Comment by Githook User [ 05/Oct/18 ] | |||
|
Author: {'name': 'Sara Golemon', 'email': 'sara.golemon@mongodb.com', 'username': 'sgolemon'}Message: | |||
| Comment by Sara Golemon [ 26/Sep/18 ] | |||
|
How should we deal with the set accessors? Example:
If we have the setters return Status, then EVERY existing callsite will need to be updated or we'll get "ignoring Status" errors. We could uassert(), and since no field has validators on them yet, that's probably fine, but may lead to surprises. I think the worst option by far is ignoring validation in this direction. | |||
| Comment by Mark Benvenuto [ 17/Sep/18 ] | |||
|
sara.golemon, you work in IDL for server parameter validators may help us build this feature in the future. |