[SERVER-37205] mongo_*.py SCons site tools clobber INSTALL_ARGS keyword args Created: 19/Sep/18  Updated: 29/Oct/23  Resolved: 08/Jul/19

Status: Closed
Project: Core Server
Component/s: Build
Affects Version/s: None
Fix Version/s: 4.3.1

Type: Bug Priority: Minor - P4
Reporter: Benjamin Caimano (Inactive) Assignee: Mathew Robinson (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Operating System: ALL
Sprint: Dev Tools 2019-07-01, Dev Tools 2019-07-15
Participants:

 Description   

As the title says, the benchmark, unittest, and integration_test site tools have lines like so:

kwargs['INSTALL_ALIAS'] = ['tests']

I believe that "test" should be added to any existing install aliases instead of replacing them. (If the "unittests" and "integration_tests" aliases were added as well while someone did this, I wouldn't complain.)



 Comments   
Comment by Andrew Morrow (Inactive) [ 09/Oct/18 ]

ben.caimano - True, that isn't ideal. However, this whole tag mechanism is sort of in an MVP state. A more sophisticated version is coming in the future. I'm going to put this in the hygienic builds epic for now so we don't forget about it, but unless it is causing active trouble right now I don't plan to change it.

Generated at Thu Feb 08 04:45:19 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.