[SERVER-37219] DocumentSourceOut::spill() and helpers should take arguments by rvalue-reference instead of const-ref Created: 19/Sep/18 Updated: 29/Oct/23 Resolved: 19/Sep/18 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Aggregation Framework |
| Affects Version/s: | None |
| Fix Version/s: | 4.1.4 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Charlie Swanson | Assignee: | Charlie Swanson |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Backwards Compatibility: | Fully Compatible |
| Sprint: | Query 2018-09-24 |
| Participants: |
| Description |
|
Doing so would allow a 'std::move' to actually do a move instead of a copy - since a std::move on a const reference compiles but does not actually allow a move. Theoretically this will speed things up, but there weren't any reliable results in some performance tests I ran. |
| Comments |
| Comment by Githook User [ 19/Sep/18 ] |
|
Author: {'name': 'Charlie Swanson', 'email': 'charlie.swanson@mongodb.com', 'username': 'cswanson310'}Message: |