[SERVER-37228] Escape double quotes in hang analyzer's waitsfor graph Created: 20/Sep/18  Updated: 29/Oct/23  Resolved: 08/Oct/18

Status: Closed
Project: Core Server
Component/s: Testing Infrastructure
Affects Version/s: None
Fix Version/s: 4.0.4, 4.1.4

Type: Bug Priority: Major - P3
Reporter: Siyuan Zhou Assignee: Max Hirschhorn
Resolution: Fixed Votes: 0
Labels: stm, tig-hanganalyzer, tig-qwin-eligible
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Related
is related to SERVER-34519 mongo_lock.py generating malformed gr... Closed
Backwards Compatibility: Fully Compatible
Backport Requested:
v4.0
Sprint: STM 2018-10-22
Participants:
Story Points: 1

 Description   

Double quotes are not always escaped right now. See this failure for an example.

# Legend:
#    Thread 1 -> Lock 1 indicates Thread 1 is waiting on Lock 1
#    Lock 2 -> Thread 2 indicates Lock 2 is held by Thread 2
# No cycle detected in the graph
digraph "mongod+lock-status" {
    ""conn41" (Thread 0x7f63bf32b700 (LWP 71045))" -> "Lock 0x7f63df74db00 (mongo::MODE_X)";
    "Lock 0x7f63df74db00 (mongo::MODE_X)" -> ""rsSync-0" (Thread 0x7f63bc818700 (LWP 69184))";
    ""repl writer worker 10" (Thread 0x7f63b460b700 (LWP 69197))" -> "Lock 0x7f63df74db00 (mongo::MODE_X)";
    ""clientcursormon" (Thread 0x7f63c2f31700 (LWP 68966))" -> "Lock 0x7f63df74db00 (mongo::MODE_X)";
    ""conn41" (Thread 0x7f63bf32b700 (LWP 71045))" [label="\"conn41\" (Thread 0x7f63bf32b700 (LWP 71045))" ]
    "Lock 0x7f63df74db00 (mongo::MODE_X)" [label="Lock 0x7f63df74db00 (mongo::MODE_X)" ]
    ""rsSync-0" (Thread 0x7f63bc818700 (LWP 69184))" [label="\"rsSync-0\" (Thread 0x7f63bc818700 (LWP 69184))" ]
    ""repl writer worker 10" (Thread 0x7f63b460b700 (LWP 69197))" [label="\"repl writer worker 10\" (Thread 0x7f63b460b700 (LWP 69197))" ]
    ""clientcursormon" (Thread 0x7f63c2f31700 (LWP 68966))" [label="\"clientcursormon\" (Thread 0x7f63c2f31700 (LWP 68966))" ]
}



 Comments   
Comment by Githook User [ 10/Oct/18 ]

Author:

{'name': 'Max Hirschhorn', 'email': 'max.hirschhorn@mongodb.com', 'username': 'visemet'}

Message: SERVER-37228 Escape ID in addition to label in waits-for graph.

(cherry picked from commit 8e46857abfa06891512ceef03fb539d7d3f47d13)
Branch: v4.0
https://github.com/mongodb/mongo/commit/ad14ee06003139bd298715b7b7c35d8451b20915

Comment by Githook User [ 08/Oct/18 ]

Author:

{'name': 'Max Hirschhorn', 'email': 'max.hirschhorn@mongodb.com', 'username': 'visemet'}

Message: SERVER-37228 Escape ID in addition to label in waits-for graph.
Branch: master
https://github.com/mongodb/mongo/commit/8e46857abfa06891512ceef03fb539d7d3f47d13

Generated at Thu Feb 08 04:45:23 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.