[SERVER-37367] Notification::waitFor is not interruptible in 3.4 Created: 28/Sep/18  Updated: 29/Oct/23  Resolved: 09/Oct/18

Status: Closed
Project: Core Server
Component/s: Internal Code
Affects Version/s: 3.4.17
Fix Version/s: 3.4.18

Type: Bug Priority: Major - P3
Reporter: Kaloian Manassiev Assignee: Jack Mulrow
Resolution: Fixed Votes: 0
Labels: neweng, sharding-wfbf-day
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
backports SERVER-25062 Implement interruptible sleep and con... Closed
Depends
Backwards Compatibility: Fully Compatible
Operating System: ALL
Sprint: Sharding 2018-10-22
Participants:
Linked BF Score: 1

 Description   

The Notification::waitFor call is not interruptible in the 3.4 branch and this could potentially cause deadlock at config server stepdown followed immediately by step-up, due to its usage in the sharding Balancer code. While the chance for such a deadlock is extremely rare, making Notification::waitFor interruptible should be very safe to include in 3.4.

We can just pick-up the changes to notification.h from this change.



 Comments   
Comment by Githook User [ 09/Oct/18 ]

Author:

{'name': 'Jack Mulrow', 'email': 'jack.mulrow@mongodb.com', 'username': 'jsmulrow'}

Message: SERVER-37367 Make Notification::waitFor interruptible
Branch: v3.4
https://github.com/mongodb/mongo/commit/963cba4e5f9a74fc7f675e204486687465a3866b

Generated at Thu Feb 08 04:45:47 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.