[SERVER-37578] Assert that a zone is associated with a shard before sharding the collection Created: 11/Oct/18 Updated: 29/Oct/23 Resolved: 25/Oct/18 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Sharding |
| Affects Version/s: | None |
| Fix Version/s: | 4.0.4, 4.1.5 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Janna Golden | Assignee: | Janna Golden |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | sharding-wfbf-day | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||||||||||||||
| Operating System: | ALL | ||||||||||||||||||||||||
| Backport Requested: |
v4.0
|
||||||||||||||||||||||||
| Sprint: | Sharding 2018-11-05 | ||||||||||||||||||||||||
| Participants: | |||||||||||||||||||||||||
| Linked BF Score: | 0 | ||||||||||||||||||||||||
| Description |
|
If sharding a collection that is associated with a zone, we should assert that the zone is associated with a shard. Currently, if a user creates tags associated with the non-existent collection "a", then tries to shard "a" we will seg fault. |
| Comments |
| Comment by Githook User [ 31/Oct/18 ] |
|
Author: {'name': 'Kaloian Manassiev', 'email': 'kaloian.manassiev@mongodb.com', 'username': 'kaloianm'}Message: (cherry picked from commit 13f7dfda95858b7941790eb3aba2ce56332ca674) |
| Comment by Githook User [ 31/Oct/18 ] |
|
Author: {'name': 'Kaloian Manassiev', 'email': 'kaloian.manassiev@mongodb.com', 'username': 'kaloianm'}Message: |
| Comment by Eric Milkie [ 30/Oct/18 ] |
|
Hi Janna, In the future, I request that your second commit have a description matching the change, and that your cherry-pick commit description contains the hashes from both commits that you squashed (you may have to edit the description manually in the editor to get that effect). Thanks! |
| Comment by Janna Golden [ 30/Oct/18 ] |
|
milkie The second commit on master was meant to fix the null pointer on windows - this commit seemed to fix the issue in my patch. I cherry-picked both commits and squashed them into one on 4.0 to avoid causing any extra BFs from this issue and because the fix was a one line change. This also passed in my evergreen patch when I tested it yesterday. I'll look into it today. |
| Comment by Eric Milkie [ 30/Oct/18 ] |
|
It seems that this commit is causing null pointer access violations in the unit test for zoned shards, but only on Windows. I noticed this in the 4.0 branch; is the master branch having problems as well? I was planning on pushing some other cherry-picks to the 4.0 branch before we freeze it tomorrow. |
| Comment by Githook User [ 29/Oct/18 ] |
|
Author: {'name': 'jannaerin', 'email': 'golden.janna@gmail.com', 'username': 'jannaerin'}Message: (cherry picked from commit e720f0b57c8ce2ecf73926b542eb2c29ab7c1bc3) |
| Comment by Githook User [ 29/Oct/18 ] |
|
Author: {'name': 'jannaerin', 'email': 'golden.janna@gmail.com', 'username': 'jannaerin'}Message: |
| Comment by Githook User [ 25/Oct/18 ] |
|
Author: {'name': 'jannaerin', 'email': 'golden.janna@gmail.com', 'username': 'jannaerin'}Message: |
| Comment by Kaloian Manassiev [ 12/Oct/18 ] |
|
janna.golden, scheduling this to you for this sprint since it is a regression and a crash. |