[SERVER-37584] Build failure on case-sensitive macOS file system: CommonHmac.h Created: 12/Oct/18  Updated: 29/Oct/23  Resolved: 24/Oct/18

Status: Closed
Project: Core Server
Component/s: Build
Affects Version/s: 4.0.3
Fix Version/s: 4.0.4, 4.1.5

Type: Bug Priority: Major - P3
Reporter: Ryan Schmidt Assignee: Patrick Freed
Resolution: Fixed Votes: 0
Labels: neweng
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Backwards Compatibility: Fully Compatible
Operating System: ALL
Backport Requested:
v4.0
Sprint: Dev Tools 2018-10-22, Security 2018-11-05
Participants:

 Description   

A user reported to MacPorts that the build fails on case-sensitive filesystems:

src/mongo/crypto/sha_block_apple.cpp:32:10: fatal error: 'CommonCrypto/CommonHmac.h' file not found
#include <CommonCrypto/CommonHmac.h>
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

This is fixed with a simple change of case:

--- src/mongo/crypto/sha_block_apple.cpp.orig	2018-09-25 16:56:42.000000000 -0500
+++ src/mongo/crypto/sha_block_apple.cpp	2018-10-11 19:28:57.000000000 -0500
@@ -29,7 +29,7 @@
 #include "mongo/platform/basic.h"
 
 #include <CommonCrypto/CommonDigest.h>
-#include <CommonCrypto/CommonHmac.h>
+#include <CommonCrypto/CommonHMAC.h>
 
 #include "mongo/crypto/sha1_block.h"
 #include "mongo/crypto/sha256_block.h"



 Comments   
Comment by Githook User [ 25/Oct/18 ]

Author:

{'name': 'Patrick Freed', 'email': 'patrick.freed@mongodb.com', 'username': 'patrickfreed'}

Message: SERVER-37584 Fix build failure on case-sensitive macOS file system: CommonHmac.h

(cherry picked from commit 887cc3f6db2a15d94e8ae2195d8183f16337d926)
Branch: v4.0
https://github.com/mongodb/mongo/commit/3a329b3fbedebeb3b693e5b735457e25c57d376c

Comment by Githook User [ 24/Oct/18 ]

Author:

{'name': 'Patrick Freed', 'email': 'patrick.freed@mongodb.com', 'username': 'patrickfreed'}

Message: SERVER-37584 Fix build failure on case-sensitive macOS file system: CommonHmac.h
Branch: master
https://github.com/mongodb/mongo/commit/887cc3f6db2a15d94e8ae2195d8183f16337d926

Comment by Andrew Morrow (Inactive) [ 19/Oct/18 ]

Based on the MacPorts ticket, we should plan to backport this to 4.0.

Comment by Andrew Morrow (Inactive) [ 12/Oct/18 ]

ryandesign - Nice find. Thanks for the bug report. We will get this fixed.

Generated at Thu Feb 08 04:46:25 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.