[SERVER-37703] TransactionRouter::commitTransaction does not need to return the coordinator's response to the caller Created: 22/Oct/18  Updated: 01/Nov/18  Resolved: 01/Nov/18

Status: Closed
Project: Core Server
Component/s: Sharding
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Major - P3
Reporter: Esha Maharishi (Inactive) Assignee: Esha Maharishi (Inactive)
Resolution: Won't Fix Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Participants:

 Description   

because TransactionRouter::commitTransaction already uasserts on the coordinator's response, so the only response that TransactionRouter::commitTransaction would return is an ok response.



 Comments   
Comment by Githook User [ 23/Oct/18 ]

Author:

{'name': 'eshamaharishi', 'email': 'em2852@columbia.edu', 'username': 'EshaMaharishi'}

Message: Revert "SERVER-37703 Put back early return that was accidentally removed from if block in TransactionRouter::commitTransaction"
This reverts commit 206c9e47924073d426df60624a539b792bd04047.
Revert "SERVER-37703 TransactionRouter::commitTransaction does not need to return the coordinator's response to the caller"
This reverts commit 7a1cf7b8cc5751cd19ced4186ab575b8827d22dd.
Branch: master
https://github.com/mongodb/mongo/commit/f1a09f94a1f17b40b096ac0e6129e693b026e915

Comment by Githook User [ 22/Oct/18 ]

Author:

{'name': 'Esha Maharishi', 'email': 'esha.maharishi@mongodb.com', 'username': 'EshaMaharishi'}

Message: SERVER-37703 Put back early return that was accidentally removed from if block in TransactionRouter::commitTransaction
Branch: master
https://github.com/mongodb/mongo/commit/206c9e47924073d426df60624a539b792bd04047

Comment by Githook User [ 22/Oct/18 ]

Author:

{'name': 'Esha Maharishi', 'email': 'esha.maharishi@mongodb.com', 'username': 'EshaMaharishi'}

Message: SERVER-37703 TransactionRouter::commitTransaction does not need to return the coordinator's response to the caller
Branch: master
https://github.com/mongodb/mongo/commit/7a1cf7b8cc5751cd19ced4186ab575b8827d22dd

Generated at Thu Feb 08 04:46:45 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.