[SERVER-37796]  Always salvage WiredTiger metadata regardless of error code when starting with repair Created: 29/Oct/18  Updated: 29/Oct/23  Resolved: 05/Nov/18

Status: Closed
Project: Core Server
Component/s: Storage
Affects Version/s: None
Fix Version/s: 4.0.5, 4.1.5

Type: Improvement Priority: Major - P3
Reporter: Louis Williams Assignee: Louis Williams
Resolution: Fixed Votes: 0
Labels: nyc
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Problem/Incident
Related
related to WT-4345 Set corruption and return salvage on ... Closed
Backwards Compatibility: Fully Compatible
Backport Requested:
v4.0, v3.6
Sprint: Storage NYC 2018-11-05
Participants:
Linked BF Score: 91

 Description   

Currently, we only attempt to salvage WiredTiger metadata when the return code from wiredtiger_open is WT_TRY_SALVAGE. Unfortunately returning this error code from all points of failure in WiredTiger is difficult. There are cases, like WT-4345, where WT_NOTFOUND is returned instead, but an unconditional salvage would have allowed --repair to succeed.

 

 



 Comments   
Comment by Githook User [ 29/Nov/18 ]

Author:

{'name': 'Louis Williams', 'email': 'louis.williams@mongodb.com', 'username': 'louiswilliams'}

Message: SERVER-37796 Always salvage WiredTiger metadata regardless of error code when starting with repair

(cherry picked from commit c7553b861796c1581c85b3cbc4e55dcc9666aa0f)
(cherry picked from commit eae0b57705a7b18362b7028c6fcb7c2469043ef4)
(cherry picked from commit 13950ba0c4dfe22de28d1a7ec724d102ad69b949)
Branch: v4.0
https://github.com/mongodb/mongo/commit/94d69adc58b1c09e04c6162b578bb3c43bf66abc

Comment by Githook User [ 06/Nov/18 ]

Author:

{'name': 'Louis Williams', 'email': 'louis.williams@mongodb.com', 'username': 'louiswilliams'}

Message: SERVER-37796 Skip log file corruption on debug builds
Branch: master
https://github.com/mongodb/mongo/commit/eae0b57705a7b18362b7028c6fcb7c2469043ef4

Comment by Githook User [ 05/Nov/18 ]

Author:

{'name': 'Louis Williams', 'email': 'louis.williams@mongodb.com', 'username': 'louiswilliams'}

Message: SERVER-37796 Always salvage WiredTiger metadata regardless of error code when starting with repair
Branch: master
https://github.com/mongodb/mongo/commit/c7553b861796c1581c85b3cbc4e55dcc9666aa0f

Generated at Thu Feb 08 04:47:03 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.