[SERVER-37867] Express `insertRecord` in terms of `insertRecords` in the RecordStore interface Created: 01/Nov/18  Updated: 29/Oct/23  Resolved: 01/Nov/18

Status: Closed
Project: Core Server
Component/s: Storage
Affects Version/s: None
Fix Version/s: 4.1.5

Type: Improvement Priority: Minor - P4
Reporter: Kaloian Manassiev Assignee: Kaloian Manassiev
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
Backwards Compatibility: Fully Compatible
Sprint: Sharding 2018-11-05
Participants:
Linked BF Score: 45

 Description   

Currently, both insertRecord and insertRecords are exposed as virtual functions on the RecordStore interface, however most implementations express insertRecords as a plain loop over insertRecord except for WiredTiger, which actually supports vectored insert.

We should inverse this order of implementation similar to insertRecordsWithDocWriter.

While there, also the timestamps input parameters to insertRecords should be made constant.



 Comments   
Comment by Githook User [ 09/Nov/18 ]

Author:

{'name': 'Kaloian Manassiev', 'email': 'kaloian.manassiev@mongodb.com', 'username': 'kaloianm'}

Message: SERVER-37867 Include the record id and the store which failed to find a record
Branch: master
https://github.com/mongodb/mongo/commit/82dcbf55d9dc2f5f9ca9033f40f6f8d5c01c1f45

Comment by Githook User [ 01/Nov/18 ]

Author:

{'name': 'Kaloian Manassiev', 'email': 'kaloian.manassiev@mongodb.com', 'username': 'kaloianm'}

Message: SERVER-37867 Cleanup the RecordStore insertRecord(s)/dataFor API
Branch: master
https://github.com/mongodb/mongo/commit/fdc3f8e561164423c03ab44b7c9525b0dc2165c4

Generated at Thu Feb 08 04:47:15 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.