[SERVER-37890] Add a callback to the ThreadPool options to create a thread client using the RAII Client helper Created: 02/Nov/18  Updated: 14/Nov/18  Resolved: 06/Nov/18

Status: Closed
Project: Core Server
Component/s: Storage
Affects Version/s: None
Fix Version/s: None

Type: Improvement Priority: Minor - P4
Reporter: Gregory Wlodarek Assignee: Gregory Wlodarek
Resolution: Won't Fix Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
is depended on by SERVER-37894 Substitute calls from Client::initThr... Closed
Sprint: Storage NYC 2018-11-05, Storage NYC 2018-11-19
Participants:

 Description   

With the introduction of the RAII Client helper class in SERVER-36473, we can further remove any references to Client::initThread or Client::initThreadIfNotAlready in the ThreadPool's onCreateThread callback.

Furthermore we can remove more unmanaged Client instances and replace them with the RAII Client helper for those that are in similarly structured ways as ThreadPools, such as stdx::thread and stdx::packaged_task.



 Comments   
Comment by Gregory Wlodarek [ 06/Nov/18 ]

I'm closing this as schwerin believes that it'd be better leaving it the way it is today. Instead of having to teach the ThreadPool about ThreadClient it would just be easier where the ThreadPool's onCreateThread() callback created ThreadClient instances where they need them.

Generated at Thu Feb 08 04:47:19 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.