[SERVER-37993] Upgrade asio to eed287d46c14310f0daf4ff19b0297917143723 Created: 07/Nov/18 Updated: 29/Oct/23 Resolved: 17/Dec/18 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Internal Code |
| Affects Version/s: | None |
| Fix Version/s: | 4.1.7, 4.0.20 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Mathew Robinson (Inactive) | Assignee: | Andrew Morrow (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||||||
| Backport Requested: |
v4.0
|
||||||||||||||||
| Sprint: | Dev Tools 2018-12-31 | ||||||||||||||||
| Participants: | |||||||||||||||||
| Linked BF Score: | 0 | ||||||||||||||||
| Comments |
| Comment by Githook User [ 24/Jul/20 ] |
|
Author: {'name': 'Andrew Morrow', 'email': 'acm@mongodb.com', 'username': 'acmorrow'}Message: |
| Comment by Githook User [ 17/Dec/18 ] |
|
Author: {'username': 'acmorrow', 'email': 'acm@mongodb.com', 'name': 'Andrew Morrow'}Message: |
| Comment by Andrew Morrow (Inactive) [ 08/Nov/18 ] |
|
OK, thanks for clarifying. |
| Comment by Mark Benvenuto [ 07/Nov/18 ] |
|
There is no changes needed to our forked copy unless in the unlikely event it stops compiling. The forked copy only forks the asio::stream and asio::context classes. The stream class is just responsible for shipping bytes from OpenSSL BIO to asio and managing state. The context class just holds a handle to OpenSSL BIO. We do not depend on ASIO for SSL context setup for instance. Things like TLS version, certificate management and other setup is all done in ssl_manager_openssl.cpp. Furthermore, when I copied these classes over, I stripped them as much as possible to minimize the amount of maintenance we will have to do going forward. Unless ASIO changes their API in some significant way or we move off ASIO, I don't foresee a need for lots of changes even as we update ASIO. This means that changes like https://github.com/chriskohlhoff/asio/commit/42a94f7cb4828139542042354a8893058fe1272f are irrelevant for us since we manage which version of TLS in ssl_manager_openssl.cpp and it has no affect on our TLS version support. |
| Comment by Andrew Morrow (Inactive) [ 07/Nov/18 ] |
|
Shouldn't we be looking to move that forward as well? |
| Comment by Mark Benvenuto [ 07/Nov/18 ] |
|
Neither Sara nor I have made any modifications to ASIO in asio-master. We have a forked copy of the ssl library in src/mongo/util/net/ssl but this will likely not affect you. |