[SERVER-38144] Remove write concern "majority" overrides for change streams test suites Created: 14/Nov/18 Updated: 29/Nov/18 Resolved: 29/Nov/18 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Querying, Replication |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Minor - P4 |
| Reporter: | William Schultz (Inactive) | Assignee: | William Schultz (Inactive) |
| Resolution: | Won't Fix | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Sprint: | Repl 2018-12-17 | ||||||||
| Participants: | |||||||||
| Description |
|
The change streams test suites all utilize the set_read_and_write_concerns.js override as a means to override write concern to "majority" on all commands run in their tests. This was presumably added originally to make sure that writes done in a test would be majority committed so as to ensure they would be visible in subsequent change stream queries (which only return majority committed data). Hopefully the reliance on "majority" write concern has been superseded by sufficient usage of assert.soon to wait for changes to appear in a stream. Getting rid of these overrides would be a nice cleanup and also make it more explicit when tests do and don't rely on majority write guarantees. |
| Comments |
| Comment by Gregory McKeon (Inactive) [ 29/Nov/18 ] |
|
It is necessary to remove the majority readConcern overrides, but removing the writeConcern overrides isn't necessary and doesn't work immediately. |
| Comment by William Schultz (Inactive) [ 14/Nov/18 ] |
|
This patch build tests the change streams suites with all read/write concern overrides disabled. There were only a couple tests that needed to be modified to make the suites pass. There may be some false positives lurking in there, but it's a promising start. |