[SERVER-38177] Repair with bind_ip results in a null pointer dereference Created: 16/Nov/18 Updated: 08/Jan/24 Resolved: 02/Jan/19 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Networking |
| Affects Version/s: | 4.0.3, 4.1.3 |
| Fix Version/s: | 4.0.6, 4.1.7 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Daniel Gottlieb (Inactive) | Assignee: | Mira Carey |
| Resolution: | Fixed | Votes: | 1 |
| Labels: | neweng | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||||||||||||||||||||||||||
| Operating System: | ALL | ||||||||||||||||||||||||||||||||||||
| Backport Requested: |
v4.0
|
||||||||||||||||||||||||||||||||||||
| Steps To Reproduce: |
|
||||||||||||||||||||||||||||||||||||
| Sprint: | Service Arch 2018-12-17, Service Arch 2018-12-31, Service Arch 2019-01-14 | ||||||||||||||||||||||||||||||||||||
| Participants: | |||||||||||||||||||||||||||||||||||||
| Description |
|
The null pointer dereference: https://github.com/mongodb/mongo/blob/dc9e1ee045af74c74360ffce2bec88868b08e1dc/src/mongo/executor/network_interface_tl.cpp#L133-L134 Also consider changing this test to examine the error code on a repair run: This patch would have surfaced the problem sooner, though I don't think anyone would reasonably pass in --bind_ip with --repair:
|
| Comments |
| Comment by Githook User [ 15/Jan/19 ] | |||||||
|
Author: {'username': 'hanumantmk', 'email': 'jcarey@argv.me', 'name': 'Jason Carey'}Message: Setting bind ips in server global params causes an error when spinning (cherry picked from commit 94f6c4d2832e4ec88b30045ceb1907af54725c78) | |||||||
| Comment by Githook User [ 02/Jan/19 ] | |||||||
|
Author: {'username': 'hanumantmk', 'email': 'jcarey@argv.me', 'name': 'Jason Carey'}Message: Setting bind ips in server global params causes an error when spinning | |||||||
| Comment by Mira Carey [ 19/Dec/18 ] | |||||||
|
gregory.wlodarek, it's not a particularly difficult fix. The error should be better, but actually fixing the behavior is just a one-liner. Should be able to get something out in the next couple of days | |||||||
| Comment by Gregory Wlodarek [ 19/Dec/18 ] | |||||||
|
mira.carey@mongodb.com, I've separated the repair work that depends on this issue into a different ticket, which isn't urgent, but it would be nice to have this unblocked in the next couple of sprints. Thanks! | |||||||
| Comment by Gregory Wlodarek [ 19/Dec/18 ] | |||||||
|
mira.carey@mongodb.com, this issue is currently blocking project work to modify --repair behavior and add some new jstest testing coverage for standalones ( | |||||||
| Comment by Dianna Hohensee (Inactive) [ 18/Dec/18 ] | |||||||
|
Cool. I just wanted to make sure that the connection was noted somewhere so it would be explained eventually – which you just did | |||||||
| Comment by Daniel Gottlieb (Inactive) [ 18/Dec/18 ] | |||||||
|
dianna.hohensee that's not quite the case. I believe the crash only happened because the repro also used --bind_ip when it launched mongod. I don't think the in-progress index builds had any affect on the outcome. Logs from running the
| |||||||
| Comment by Dianna Hohensee (Inactive) [ 18/Dec/18 ] | |||||||
|
This was repro'ed in | |||||||
| Comment by Spencer Jackson [ 19/Nov/18 ] | |||||||
|
We took a look at this, and the crash seems to be occurring in the transport layer. |