[SERVER-38274] add const to prepareUpdate function declaration Created: 27/Nov/18 Updated: 29/Oct/23 Resolved: 25/Sep/19 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 4.3.1 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Louis Williams | Assignee: | Haley Connelly |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | neweng | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Backwards Compatibility: | Fully Compatible |
| Sprint: | Execution Team 2019-10-07 |
| Participants: |
| Description |
|
prepareUpdate() can be changed to const.
Old Description: There is only one caller of validateUpdate() and update(). After |
| Comments |
| Comment by Githook User [ 24/Sep/19 ] |
|
Author: {'name': 'Haley Connelly', 'username': 'haleyConnelly', 'email': 'haley.connelly@10gen.com'}Message: |
| Comment by Haley Connelly [ 23/Sep/19 ] |
|
After discussion, we decided this change is no longer necessary. However, we can improve prepareUpdate() be making it const. |
| Comment by Gregory Noma [ 03/Jul/19 ] |
|
louis.williams The contents of prepareUpdate(), which was formerly called validateUpdate(), can still be moved inside of _updateRecord() if that's what we want to do. |
| Comment by Louis Williams [ 02/Jul/19 ] |
|
gregory.noma is this change necessary anymore? |
| Comment by Louis Williams [ 31/May/19 ] |
|
Postponing this because I'm pretty sure it conflicts with |