[SERVER-38316] Consolidate PlanExecutor::DEAD and PlanExecutor::FAILURE Created: 29/Nov/18 Updated: 29/Oct/23 Resolved: 04/Feb/19 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Querying |
| Affects Version/s: | None |
| Fix Version/s: | 4.1.8 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | David Storch | Assignee: | Pawel Terlecki |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | storch | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Backwards Compatibility: | Fully Compatible |
| Sprint: | Query 2019-01-28 |
| Participants: |
| Description |
|
PlanExecutor::getNext() has two return codes to indicate that an error occurred during query execution: DEAD and FAILURE. These two return codes don't have a strong conceptual distinction, and nearly all callers handle them in the same way. Furthermore, there are only a few known ways in which a PlanExecutor can produce DEAD:
As a simplification, we could change the PlanExecutor to return FAILURE in all cases, which would prevent callers from having to remember to handle multiple getNext() error codes. |
| Comments |
| Comment by Githook User [ 04/Feb/19 ] |
|
Author: {'name': 'Pawel Terlecki', 'email': 'pawel.terlecki@mongodb.com', 'username': 'pterlecki'}Message: Takes care of PlanExecutor states. In some cases we log more |
| Comment by Githook User [ 30/Jan/19 ] |
|
Author: {'username': 'pterlecki', 'email': 'pawel.terlecki@mongodb.com', 'name': 'Pawel Terlecki'}Message: Replaced PlanStage::DEAD with PlanStage::FAILURE. In the subsequent |