[SERVER-38464] Add setParameter for custom FTDC data directory Created: 07/Dec/18  Updated: 29/Oct/23  Resolved: 24/Jan/19

Status: Closed
Project: Core Server
Component/s: Diagnostics
Affects Version/s: None
Fix Version/s: 4.1.8

Type: Improvement Priority: Major - P3
Reporter: Benjamin Caimano (Inactive) Assignee: Mark Benvenuto
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
is depended on by SERVER-37151 Allow logs to be created with differe... Closed
Duplicate
is duplicated by SERVER-30823 Allow FTDC output directory to be con... Closed
Backwards Compatibility: Fully Compatible
Sprint: Security 2018-12-31, Security 2019-01-14, Security 2019-01-28
Participants:

 Description   

Currently, the FTDC diagnostics directory is always relative to the data directory. If we allow it to be set via setParameter, we can then put these directories in a custom subdir of the data directory during testing. This will allow us to easily archive this data for help with understanding BFs.

For reference:

bencaimano@just-ben-book:/Users/bencaimano/git/mongodb/mongo [1]$ git grep kFTDCDefaultDirectory
src/mongo/db/ftdc/constants.h:constexpr StringData kFTDCDefaultDirectory = "diagnostic.data"_sd;
src/mongo/db/ftdc/ftdc_mongod.cpp:    dir /= kFTDCDefaultDirectory.toString();
src/mongo/db/ftdc/util.cpp:    base += "." + kFTDCDefaultDirectory.toString();

CC mark.benvenuto



 Comments   
Comment by Githook User [ 24/Jan/19 ]

Author:

{'email': 'mark.benvenuto@mongodb.com', 'name': 'Mark Benvenuto', 'username': 'markbenvenuto'}

Message: SERVER-38464 Add setParameter for custom FTDC data directory
Branch: master
https://github.com/mongodb/mongo/commit/731bc64f8dbbee1def448b10feca305887bdc180

Comment by Benjamin Caimano (Inactive) [ 07/Dec/18 ]

bruce.lucas, yes, definitely. I had forgotten that we document any setParameters. This one should not be.

Comment by Bruce Lucas (Inactive) [ 07/Dec/18 ]

This sounds reasonable as a testing parameter for internal use, but I think not such a good idea for customer use because it makes support more difficult - if a customer has changed this we can't just ask them to provide us with "diagnostic.data/". Can we keep this as an undocumented internal parameter?

Comment by Benjamin Caimano (Inactive) [ 07/Dec/18 ]

So perhaps this ticket would just be moving this into a more general compilation unit?

Comment by Mark Benvenuto [ 07/Dec/18 ]

There is a startup setParameter in mongos named "diagnosticDataCollectionDirectoryPath" already. There is no way to set it on mongod currently.

Generated at Thu Feb 08 04:49:01 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.