[SERVER-38482] Mongo shell links in a lot of query code Created: 07/Dec/18 Updated: 10/Jan/19 Resolved: 10/Jan/19 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Querying |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Ian Boros | Assignee: | Ian Boros |
| Resolution: | Won't Fix | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Sprint: | Query 2018-12-31, Query 2019-01-14 |
| Participants: |
| Description |
|
It looks like we link in index_key_validate, which includes things like the expression library (both for find and aggregate) into the shell. Most (all?) of this code shouldn't be needed in the shell. |
| Comments |
| Comment by Craig Homa [ 13/Dec/18 ] |
|
If the build is green after doing this, push. If not, don't push and close as won't fix. |
| Comment by Andrew Morrow (Inactive) [ 11/Dec/18 ] |
|
ian.boros - To investigate, you can do a build of the shell with --link-model=dynamic and run ldd on the shell to see if the expression library is still linked. |
| Comment by Ian Boros [ 10/Dec/18 ] |
|
I ran a partial patch build, deleting that one line and it came out green. Unless there's another link between those two libraries, this may be easy. https://evergreen.mongodb.com/version/5c0b00732fbabe1abf917810 |