[SERVER-38512] Implement disconnection behavior for OP_MSG Created: 10/Dec/18  Updated: 29/Oct/23  Resolved: 08/Jan/19

Status: Closed
Project: Core Server
Component/s: Replication
Affects Version/s: None
Fix Version/s: 4.1.7

Type: New Feature Priority: Major - P3
Reporter: Gregory McKeon (Inactive) Assignee: A. Jesse Jiryu Davis
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
depends on SERVER-38510 Implement shell code to set moreToCom... Closed
is depended on by SERVER-38516 Remove “closeConnectionsOnStepdown” f... Closed
Documented
is documented by DOCS-12352 Docs for SERVER-38512: Implement disc... Closed
is documented by DOCS-12372 Docs for SERVER-38755: Stop closing c... Closed
Backwards Compatibility: Fully Compatible
Sprint: Repl 2019-01-14
Participants:

 Description   

Testing should include:

  • that unacknowledged writes to a secondary result in a disconnection.
  • that unacknowledged writes in progress when a stepdown occurs result in a disconnection.


 Comments   
Comment by Githook User [ 08/Jan/19 ]

Author:

{'username': 'ajdavis', 'email': 'jesse@mongodb.com', 'name': 'A. Jesse Jiryu Davis'}

Message: SERVER-38512 Test that secondary hangs up on w: 0 writes
Branch: master
https://github.com/mongodb/mongo/commit/dd9be1adf2425c7ddd746ff6da75d564474ebed3

Comment by A. Jesse Jiryu Davis [ 17/Dec/18 ]

Awaiting SERVER-38510, which is in code review.

Comment by Tess Avitabile (Inactive) [ 13/Dec/18 ]

Since this behavior is untested, the ticket should at least add testing. If the behavior does not work, it also includes implementation.

Comment by A. Jesse Jiryu Davis [ 13/Dec/18 ]

Already implemented I think. We throw from receivedCommands() if a message with moreToCome got a NotMaster error. Up the call chain, ServiceStateMachine::_runNextInGuard() catches the exception and closes the connection.

Generated at Thu Feb 08 04:49:10 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.