[SERVER-38527] Reduce the number of supports*() functions for timestamps in the storage engine API Created: 11/Dec/18  Updated: 13/May/20  Resolved: 13/May/20

Status: Closed
Project: Core Server
Component/s: Storage
Affects Version/s: None
Fix Version/s: None

Type: Improvement Priority: Major - P3
Reporter: Gregory Wlodarek Assignee: Gregory Wlodarek
Resolution: Won't Do Votes: 0
Labels: neweng
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
is depended on by SERVER-37498 remove slowBackgroundIndexBuild failp... Closed
is depended on by SERVER-38671 remove server parameter for KV drop-p... Closed
Problem/Incident
Related
Sprint: Storage NYC 2018-12-31, Storage NYC 2019-01-14, Execution Team 2020-05-18
Participants:
Linked BF Score: 41

 Description   

Today in the storage engine API, there are many supports*() functions for enabling timestamp support. We can reduce these down to one function called supportsTimestamps() and remove the additional ones.



 Comments   
Comment by Gregory Wlodarek [ 13/May/20 ]

Upon revisiting this, the only time that supportsRecoveryTimestamp() and supportsRecoverToStableTimestamp() will yield different values is when majority read concern is off. Until we remove support for majority read concern off, there is not much we can do here in terms of merging these two functions. I will be closing this as won't do.

Comment by Githook User [ 23/Jan/19 ]

Author:

{'email': 'gregory.wlodarek@mongodb.com', 'name': 'Gregory Wlodarek', 'username': 'GWlodarek'}

Message: Revert "SERVER-38527 Merge supportsRecoverToStableTimestamp into supportsRecoveryTimestamp"

This reverts commit b54951b484b2cba44ffa424f43acb870365e3f12.
Branch: master
https://github.com/mongodb/mongo/commit/87ca277a86cba6fb7e129e341e8785eada8a1589

Comment by Githook User [ 23/Jan/19 ]

Author:

{'username': 'GWlodarek', 'email': 'gregory.wlodarek@mongodb.com', 'name': 'Gregory Wlodarek'}

Message: Revert "SERVER-38527 Merge supportsRecoverToStableTimestamp into supportsRecoveryTimestamp"

This reverts commit 187af81ae89c4b8ad99b977df472e811ad7e9a17.
Branch: master
https://github.com/10gen/mongo-enterprise-modules/commit/472da9c88823bf9243be183f0714093a2528993c

Comment by Githook User [ 11/Jan/19 ]

Author:

{'username': 'GWlodarek', 'email': 'gregory.wlodarek@mongodb.com', 'name': 'Gregory Wlodarek'}

Message: SERVER-38527 Merge supportsRecoverToStableTimestamp into supportsRecoveryTimestamp
Branch: master
https://github.com/mongodb/mongo/commit/b54951b484b2cba44ffa424f43acb870365e3f12

Comment by Githook User [ 11/Jan/19 ]

Author:

{'username': 'GWlodarek', 'email': 'gregory.wlodarek@mongodb.com', 'name': 'Gregory Wlodarek'}

Message: SERVER-38527 Merge supportsRecoverToStableTimestamp into supportsRecoveryTimestamp
Branch: master
https://github.com/10gen/mongo-enterprise-modules/commit/187af81ae89c4b8ad99b977df472e811ad7e9a17

Comment by Githook User [ 04/Jan/19 ]

Author:

{'username': 'GWlodarek', 'email': 'gregory.wlodarek@mongodb.com', 'name': 'Gregory Wlodarek'}

Message: Revert "SERVER-38527 Merge supportsRecoverToStableTimestamp into supportsRecoveryTimestamp"

This reverts commit 804617152c5b4f89c8d54c83bdea90cb2c8541b4.
Branch: master
https://github.com/mongodb/mongo/commit/e4fe8b89a9ce01a3571114e9c51a4cdd725fbe1d

Comment by Githook User [ 04/Jan/19 ]

Author:

{'username': 'GWlodarek', 'email': 'gregory.wlodarek@mongodb.com', 'name': 'Gregory Wlodarek'}

Message: Revert "SERVER-38527 Merge supportsRecoverToStableTimestamp into supportsRecoveryTimestamp"

This reverts commit 90fa62c15b0693145913aaf6e9a3a5020a771502.
Branch: master
https://github.com/10gen/mongo-enterprise-modules/commit/1d1b372dafe949f59fb3bf98a426857891e469cf

Comment by Githook User [ 04/Jan/19 ]

Author:

{'username': 'GWlodarek', 'email': 'gregory.wlodarek@mongodb.com', 'name': 'Gregory Wlodarek'}

Message: SERVER-38527 Merge supportsRecoverToStableTimestamp into supportsRecoveryTimestamp
Branch: master
https://github.com/mongodb/mongo/commit/804617152c5b4f89c8d54c83bdea90cb2c8541b4

Comment by Githook User [ 04/Jan/19 ]

Author:

{'username': 'GWlodarek', 'email': 'gregory.wlodarek@mongodb.com', 'name': 'Gregory Wlodarek'}

Message: SERVER-38527 Merge supportsRecoverToStableTimestamp into supportsRecoveryTimestamp
Branch: master
https://github.com/10gen/mongo-enterprise-modules/commit/90fa62c15b0693145913aaf6e9a3a5020a771502

Generated at Thu Feb 08 04:49:12 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.