[SERVER-38527] Reduce the number of supports*() functions for timestamps in the storage engine API Created: 11/Dec/18 Updated: 13/May/20 Resolved: 13/May/20 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Storage |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Gregory Wlodarek | Assignee: | Gregory Wlodarek |
| Resolution: | Won't Do | Votes: | 0 |
| Labels: | neweng | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||
| Sprint: | Storage NYC 2018-12-31, Storage NYC 2019-01-14, Execution Team 2020-05-18 | ||||||||||||||||||||
| Participants: | |||||||||||||||||||||
| Linked BF Score: | 41 | ||||||||||||||||||||
| Description |
|
Today in the storage engine API, there are many supports*() functions for enabling timestamp support. We can reduce these down to one function called supportsTimestamps() and remove the additional ones. |
| Comments |
| Comment by Gregory Wlodarek [ 13/May/20 ] |
|
Upon revisiting this, the only time that supportsRecoveryTimestamp() and supportsRecoverToStableTimestamp() will yield different values is when majority read concern is off. Until we remove support for majority read concern off, there is not much we can do here in terms of merging these two functions. I will be closing this as won't do. |
| Comment by Githook User [ 23/Jan/19 ] |
|
Author: {'email': 'gregory.wlodarek@mongodb.com', 'name': 'Gregory Wlodarek', 'username': 'GWlodarek'}Message: Revert " This reverts commit b54951b484b2cba44ffa424f43acb870365e3f12. |
| Comment by Githook User [ 23/Jan/19 ] |
|
Author: {'username': 'GWlodarek', 'email': 'gregory.wlodarek@mongodb.com', 'name': 'Gregory Wlodarek'}Message: Revert " This reverts commit 187af81ae89c4b8ad99b977df472e811ad7e9a17. |
| Comment by Githook User [ 11/Jan/19 ] |
|
Author: {'username': 'GWlodarek', 'email': 'gregory.wlodarek@mongodb.com', 'name': 'Gregory Wlodarek'}Message: |
| Comment by Githook User [ 11/Jan/19 ] |
|
Author: {'username': 'GWlodarek', 'email': 'gregory.wlodarek@mongodb.com', 'name': 'Gregory Wlodarek'}Message: |
| Comment by Githook User [ 04/Jan/19 ] |
|
Author: {'username': 'GWlodarek', 'email': 'gregory.wlodarek@mongodb.com', 'name': 'Gregory Wlodarek'}Message: Revert " This reverts commit 804617152c5b4f89c8d54c83bdea90cb2c8541b4. |
| Comment by Githook User [ 04/Jan/19 ] |
|
Author: {'username': 'GWlodarek', 'email': 'gregory.wlodarek@mongodb.com', 'name': 'Gregory Wlodarek'}Message: Revert " This reverts commit 90fa62c15b0693145913aaf6e9a3a5020a771502. |
| Comment by Githook User [ 04/Jan/19 ] |
|
Author: {'username': 'GWlodarek', 'email': 'gregory.wlodarek@mongodb.com', 'name': 'Gregory Wlodarek'}Message: |
| Comment by Githook User [ 04/Jan/19 ] |
|
Author: {'username': 'GWlodarek', 'email': 'gregory.wlodarek@mongodb.com', 'name': 'Gregory Wlodarek'}Message: |