[SERVER-38595] atomic_word.h, typedefs are misleading, nonportable, noncompliant Created: 13/Dec/18 Updated: 29/Oct/23 Resolved: 07/Jan/19 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Internal Code |
| Affects Version/s: | None |
| Fix Version/s: | 4.1.7 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Billy Donahue | Assignee: | Billy Donahue |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Backwards Compatibility: | Fully Compatible |
| Operating System: | ALL |
| Sprint: | Dev Tools 2018-12-31, Dev Tools 2019-01-14 |
| Participants: |
| Description |
|
In a few places, the header uses identifiers with leading underscore and capital letter, which are reserved. _ATOMIC_WORD_DECLARE(AtomicUInt32, unsigned); People think AtomicInt32 wraps int32_t and it doesn't. Also we don't need the _ATOMIC_WORD_DECLARE structure. |
| Comments |
| Comment by Billy Donahue [ 07/Jan/19 ] |
|
typedefs removed by https://github.com/mongodb/mongo/commit/11bb071e91461b1f8e40b9b15ddf |
| Comment by Githook User [ 07/Jan/19 ] |
|
Author: {'username': 'BillyDonahue', 'email': 'billy.donahue@mongodb.com', 'name': 'Billy Donahue'}Message: |
| Comment by Billy Donahue [ 21/Dec/18 ] |
|
The macros would be eliminated by The integer rank problems would still remain though. |