[SERVER-38603] KV Storage Engine should defer removing idents by registering the ident with the KVDropPendingIdentReaper Created: 13/Dec/18 Updated: 29/Oct/23 Resolved: 23/Dec/18 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Storage |
| Affects Version/s: | None |
| Fix Version/s: | 4.1.7 |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Benety Goh | Assignee: | Benety Goh |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Backwards Compatibility: | Fully Compatible |
| Sprint: | Storage NYC 2018-12-31 |
| Participants: |
| Description |
|
In DatabaseImpl::dropCollectionEvenIfSystem(), we currently rename the collection to a <db>.system.drop.* namespace. With drop-pending ident support, we will instead invoke _finishDropCollection() to remove the collection from the catalog. Subsequently, the KV storage engine will remove the collection from the KVCatalog. Rather than dropping the ident, the KVDatabaseCatalogEntryBase::RemoveCollectionChange will register the ident with the KVDropPendingIdentReaper using the commit timestamp from the RecoveryUnit. With the new Timestamp notifier introduced in |
| Comments |
| Comment by Githook User [ 23/Dec/18 ] |
|
Author: {'username': 'benety', 'email': 'benety@mongodb.com', 'name': 'Benety Goh'}Message: If drop-pending idents are supported by the storage engine, this disables the replication |
| Comment by Githook User [ 22/Dec/18 ] |
|
Author: {'username': 'benety', 'email': 'benety@mongodb.com', 'name': 'Benety Goh'}Message: These fields are always set to true. The code that used to set these fields to false |
| Comment by Githook User [ 22/Dec/18 ] |
|
Author: {'username': 'benety', 'email': 'benety@mongodb.com', 'name': 'Benety Goh'}Message: This helps to break the curcular dependency between KVDatabaseCatalogEntryBase |
| Comment by Githook User [ 22/Dec/18 ] |
|
Author: {'username': 'benety', 'email': 'benety@mongodb.com', 'name': 'Benety Goh'}Message: |