[SERVER-38638] Fix acos function in IntelRDFPMathLib20U1 Created: 14/Dec/18  Updated: 29/Oct/23  Resolved: 20/Dec/18

Status: Closed
Project: Core Server
Component/s: Querying
Affects Version/s: None
Fix Version/s: 4.1.7

Type: Improvement Priority: Major - P3
Reporter: Geert Bosch Assignee: Geert Bosch
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
is depended on by SERVER-32930 Trig functions in the aggregation fra... Closed
Related
related to SERVER-37998 Upgrade Intel Decimal FP Library to a... Backlog
Backwards Compatibility: Fully Compatible
Sprint: Storage NYC 2018-12-31
Participants:

 Description   

The acos function in the NumberDecimal library has a bug for special-case argument handling, where acos(-1.0) returns 0 rather than Pi. For SERVER-32930 we are implementing the $acos expression and need this fixed. The new IntelRDFPMathLib20U2 June 2018 update of the library has this big fix, but seems to have either introduced a new issue in code changes for the power function, or exposes optimization bugs in GCC. So it looks like SERVER-37998 might take longer to do than expected.

So, we should for now just cherry-pick this change and associated test cases in readtest.in while we wait for upgrade of the library as a whole.



 Comments   
Comment by Githook User [ 20/Dec/18 ]

Author:

{'username': 'GeertBosch', 'email': 'geert@mongodb.com', 'name': 'Geert Bosch'}

Message: SERVER-38638 Cherry-pick bid128_acos fix for -1 argument value
Branch: master
https://github.com/mongodb/mongo/commit/08b74e137705941411704d4c26ed7d8b16eb0a00

Generated at Thu Feb 08 04:49:32 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.