[SERVER-38685] Startup warning if In-Memory SE is used and writeConcernMajorityJournalDefault is true Created: 18/Dec/18 Updated: 29/Oct/23 Resolved: 04/Jun/19 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Replication |
| Affects Version/s: | 4.0.4 |
| Fix Version/s: | 3.6.15, 4.2.0-rc0, 4.0.13 |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Danny Hatcher (Inactive) | Assignee: | Vishnu Kaushik |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | former-quick-wins, neweng | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||||||||||||||||||
| Backport Requested: |
v4.0, v3.6
|
||||||||||||||||||||||||||||
| Sprint: | Repl 2019-06-03, Repl 2019-06-17 | ||||||||||||||||||||||||||||
| Participants: | |||||||||||||||||||||||||||||
| Description |
|
We should a startup warning if a node is using the In-Memory storage engine but has also enabled writeConcernMajorityJournalDefault. Per the documentation, that option is unsupported in replica sets that contain In-Memory nodes and can cause problems if not set to false. |
| Comments |
| Comment by Githook User [ 19/Aug/19 ] |
|
Author: {'username': 'kauboy26', 'email': 'vishnu.kaushik@mongodb.com', 'name': 'Vishnu Kaushik'}Message: (cherry picked from commit 1ae9c35e4b8ae754fe49075f7f729bccb256e7d0) |
| Comment by Githook User [ 19/Aug/19 ] |
|
Author: {'name': 'Vishnu Kaushik', 'email': 'vishnu.kaushik@mongodb.com', 'username': 'kauboy26'}Message: (cherry picked from commit 1ae9c35e4b8ae754fe49075f7f729bccb256e7d0) |
| Comment by Githook User [ 31/May/19 ] |
|
Author: {'name': 'Vishnu Kaushik', 'email': 'vishnu.kaushik@mongodb.com'}Message: |
| Comment by Eric Milkie [ 19/Dec/18 ] |
|
You could do that, but that would imply that we would now have a warning that would always fire and yet be ignorable in some cases, and I am trying hard to avoid such "nuisance" warnings. In light of this, I've changed my mind – we should always print the warning, regardless of voting-ness. It doesn't hurt anything to turn on writeConcernMajorityJournalDefault on non-voting nodes, and that action will suppress the warning in all cases. |
| Comment by Tess Avitabile (Inactive) [ 19/Dec/18 ] |
|
This also applies to the warning about --nojournal and writeConcernMajorityJournalDefault. For both of the warnings, we could include language that the warning only applies if the node has votes. |
| Comment by Eric Milkie [ 19/Dec/18 ] |
|
I still worry about confusion here. Ideally, we wouldn't show the warning unless the node was a voting node, but I think at the time of composing the startup warnings we don't yet have the replica set config to know that information. |
| Comment by Tess Avitabile (Inactive) [ 18/Dec/18 ] |
|
We can extend this startup warning. |