[SERVER-38730] struct ByteOrderConverter<Decimal128::Value> is a noop Created: 20/Dec/18  Updated: 29/Oct/23  Resolved: 31/Dec/18

Status: Closed
Project: Core Server
Component/s: Storage
Affects Version/s: None
Fix Version/s: 4.1.7

Type: Bug Priority: Major - P3
Reporter: Geert Bosch Assignee: Gregory Wlodarek
Resolution: Fixed Votes: 0
Labels: neweng
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Operating System: ALL
Sprint: Storage NYC 2018-12-31
Participants:

 Description   

The code (see here) doesn't actually change t, as the results of the conversion calls are not assigned back.

This code is used for the aggregation values, but not for serializing BSON, which independently converts the high and low uint64_t parts of the Decimal128::Value representation, so it doesn't affect stored data.



 Comments   
Comment by Githook User [ 31/Dec/18 ]

Author:

{'username': 'GWlodarek', 'email': 'gregory.wlodarek@mongodb.com', 'name': 'Gregory Wlodarek'}

Message: SERVER-38730 fix struct ByteOrderConverter<Decimal128::Value> to return the converted struct
Branch: master
https://github.com/mongodb/mongo/commit/6216c1f39ca10f148a82cb2b9bba0bd2b61c8793

Generated at Thu Feb 08 04:49:50 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.