[SERVER-38859] txn_override.js should make sure failing assert.commandWorked() terminates the test during collection creation Created: 04/Jan/19 Updated: 06/Dec/22 Resolved: 07/Jan/19 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Replication, Sharding, Testing Infrastructure |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Samyukta Lanka | Assignee: | Backlog - Replication Team |
| Resolution: | Duplicate | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Assigned Teams: |
Replication
|
||||||||
| Operating System: | ALL | ||||||||
| Participants: | |||||||||
| Description |
|
In txn_override.js, if an insert attempts to do implicit collection creation inside a transaction, we will abort the transaction, create the collection outside of a transaction, and retry the transaction. If the collection creation fails this assert.commandWorked(), it does not necessarily terminate the test because the error could be caught in auto_retry_on_network_error.js and cause the transaction to be retried. This is a problem because rather than failing loudly for an error we did not expect, we are suppressing the error by retrying the transaction. |
| Comments |
| Comment by Samyukta Lanka [ 07/Jan/19 ] |
|
judah.schvimer, yes it is. I'm marking it as a duplicate and closing now |
| Comment by Judah Schvimer [ 07/Jan/19 ] |
|
samy.lanka and siyuan.zhou, is this a duplicate of |