[SERVER-38937] Unify txn_override.js and auto_retry_on_network_error.js Created: 10/Jan/19  Updated: 29/Oct/23  Resolved: 04/Apr/19

Status: Closed
Project: Core Server
Component/s: Replication, Sharding, Testing Infrastructure
Affects Version/s: None
Fix Version/s: 4.1.10

Type: Task Priority: Major - P3
Reporter: Judah Schvimer Assignee: Judah Schvimer
Resolution: Fixed Votes: 0
Labels: open_todo_in_code, prepare_testing
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
depends on SERVER-38936 Create unittests for txn_override.js Closed
is depended on by SERVER-39702 Remove config server as transaction c... Closed
is depended on by SERVER-39990 Add sharded jscore txn_override passt... Closed
Duplicate
is duplicated by SERVER-38778 Improve error handling on implicit co... Closed
is duplicated by SERVER-38856 txn_override.js should not rerun ever... Closed
is duplicated by SERVER-38857 txn_override.js shouldn't have a writ... Closed
is duplicated by SERVER-39117 Must deep-copy objects in ops array i... Closed
is duplicated by SERVER-38814 Re-enable transaction kill / terminat... Closed
Related
related to SERVER-60823 runCommandWithRetries in JS test fram... Backlog
related to SERVER-38777 createCollection should not return ok... Closed
is related to SERVER-39890 Make network_error_and_txn_override.j... Closed
Backwards Compatibility: Fully Compatible
Sprint: Repl 2019-01-28, Repl 2019-02-11, Repl 2019-02-25, Repl 2019-03-11, Repl 2019-03-25, Repl 2019-04-08
Participants:
Linked BF Score: 7

 Description   

Having one retry loop rather than many would make this way easier to get right.



 Comments   
Comment by Githook User [ 04/Apr/19 ]

Author:

{'email': 'judah@mongodb.com', 'name': 'Judah Schvimer', 'username': 'judahschvimer'}

Message: SERVER-38937 unify txn override and auto retry on network error
Branch: master
https://github.com/mongodb/mongo/commit/5ab3575979e020eddf7515f21bf72eabc2cac7cd

Comment by Siyuan Zhou [ 10/Jan/19 ]

Whenever we retry an operation, it'll be great to log what request and error triggered this retry, why we are retrying and what operations we are retrying, for example, around implicit collection creation.

Comment by Judah Schvimer [ 10/Jan/19 ]

janna.golden, max.hirschhorn, jack.mulrow, siyuan.zhou if you have any thoughts on the best way to do this, please add them here!

siyuan.zhou, can you please describe what logging you'd like this unification to add?

Comment by Judah Schvimer [ 10/Jan/19 ]

We will first create the tests based on the original txn_override.js in SERVER-38936 and then unify the overrides to make them more readable.

Generated at Thu Feb 08 04:50:31 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.