[SERVER-38957] Allow a failed changelog write in movePrimary's cleanupOnError to silently fail. Created: 11/Jan/19  Updated: 29/Oct/23  Resolved: 20/Jan/19

Status: Closed
Project: Core Server
Component/s: Sharding
Affects Version/s: 4.0.5, 4.1.6
Fix Version/s: 4.0.6, 4.1.8

Type: Task Priority: Major - P3
Reporter: Blake Oler Assignee: Blake Oler
Resolution: Fixed Votes: 0
Labels: neweng, sharding-wfbf-day
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Depends
Duplicate
is duplicated by SERVER-37292 MovePrimarySourceManager can throw un... Closed
Backwards Compatibility: Fully Compatible
Backport Requested:
v4.0
Sprint: Sharding 2019-01-28
Participants:
Linked BF Score: 45

 Description   

The given contract for changelog writes is that these writes are "best-effort," implying that we should not assert on their success. This case in particular is problematic because it's inside a scopedGuard. When an exception is not caught from inside a scopedGuard, it causes std::terminate to be called.

This ticket is to simply change the call from logChangeChecked to logChange, and then remove the uassertStatusOK.



 Comments   
Comment by Githook User [ 05/Feb/19 ]

Author:

{'name': 'Blake Oler', 'email': 'blake.oler@mongodb.com', 'username': 'BlakeIsBlake'}

Message: SERVER-38957 Allow a failed changelog write in movePrimary's cleanupOnError to silently fail.

(cherry picked from commit 9cf00022b936cdb3c2234235d5aaa6be7ef6146a)
Branch: v4.0
https://github.com/mongodb/mongo/commit/46c77f1f2abc4c4dc44957ea8838dd59e01a2e41

Comment by Githook User [ 20/Jan/19 ]

Author:

{'username': 'BlakeIsBlake', 'email': 'blake.oler@mongodb.com', 'name': 'Blake Oler'}

Message: SERVER-38957 Allow a failed changelog write in movePrimary's cleanupOnError to silently fail.
Branch: master
https://github.com/mongodb/mongo/commit/9cf00022b936cdb3c2234235d5aaa6be7ef6146a

Generated at Thu Feb 08 04:50:34 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.