[SERVER-38961] Remove override for causally consistent index builds once two-phase index builds are complete Created: 11/Jan/19  Updated: 29/Oct/23  Resolved: 08/May/20

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 4.7.0

Type: Task Priority: Major - P3
Reporter: Louis Williams Assignee: Benety Goh
Resolution: Fixed Votes: 0
Labels: open_todo_in_code, techdebt
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
depends on SERVER-43692 enable two phase index builds by default Closed
Related
related to SERVER-26624 Create test command that will block u... Closed
related to SERVER-37270 Remove foreground index build functio... Closed
related to SERVER-52990 Complete TODO listed in SERVER-38961 Closed
is related to SERVER-45201 Implicit collection creation from cre... Closed
is related to SERVER-47182 Single-phase index builds should run ... Closed
Backwards Compatibility: Fully Compatible
Sprint: Execution Team 2020-05-04, Execution Team 2020-05-18
Participants:

 Description   

Introduced by SERVER-37270 because background index builds (the default) complete asynchronously on secondaries.

The causally_consistent_index_build override should no longer be necessary: https://github.com/mongodb/mongo/blob/fbc1a0f4c1c34be2e0ba390b750144b4c7919061/jstests/libs/override_methods/causally_consistent_index_builds.js#L3



 Comments   
Comment by Githook User [ 07/May/20 ]

Author:

{'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}

Message: SERVER-38961 remove supportsTwoPhaseIndexBuild field from storageEngine server status section

This field is used for testing only and is no longer required.
Branch: master
https://github.com/mongodb/mongo/commit/32bdf48d824c7156fa26aa6a0dcf3665b09d792b

Comment by Githook User [ 07/May/20 ]

Author:

{'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}

Message: SERVER-38961 remove IndexBuildTest.supportsTwoPhaseIndexBuild()
Branch: master
https://github.com/mongodb/mongo/commit/fb73b392070e41a6c43c5fcaf44f1700baab0f4e

Comment by Githook User [ 07/May/20 ]

Author:

{'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}

Message: SERVER-38961 remove characterize_index_builds_on_restart.js

This test is only applicable when there is no support for two phase index builds.
Branch: master
https://github.com/mongodb/mongo/commit/f1b99df506fdd4dbb45a12f042fff6b2defc91da

Comment by Githook User [ 07/May/20 ]

Author:

{'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}

Message: SERVER-38961 remove IndexBuildTest.supportsTwoPhaseIndexBuild() references from jsCore and disk tests
Branch: master
https://github.com/mongodb/mongo/commit/02394766d7aa0f17a9fbf826e9767ae40e41c59a

Comment by Githook User [ 07/May/20 ]

Author:

{'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}

Message: SERVER-38961 remove IndexBuildTest.supportsTwoPhaseIndexBuild() references from noPassthrough tests
Branch: master
https://github.com/mongodb/mongo/commit/474e6228cf95e16aa205256a0f15ef9f9388252d

Comment by Githook User [ 07/May/20 ]

Author:

{'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}

Message: SERVER-38961 remove IndexBuildTest.supportsTwoPhaseIndexBuild() references from replsets tests
Branch: master
https://github.com/mongodb/mongo/commit/03df68b3e2fb6d6d30dea41a581e3c3aec874f33

Comment by Githook User [ 07/May/20 ]

Author:

{'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}

Message: SERVER-38961 remove IndexBuildsCoordinator::supportsTwoPhaseIndexBuild()
Branch: master
https://github.com/mongodb/mongo/commit/7ede858f0d22e9a7dcd1fb9e44ccede51b624d0d

Comment by Githook User [ 04/May/20 ]

Author:

{'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}

Message: SERVER-38961 remove StorageEngine::supportsTwoPhaseIndexBuild()
Branch: master
https://github.com/mongodb/mongo/commit/6f63d9ad2889ba8f16d486862f87f0965e8c5a2c

Comment by Githook User [ 04/May/20 ]

Author:

{'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}

Message: SERVER-38961 supportsTwoPhaseIndexBuild in storageEngine server status section always returns true
Branch: master
https://github.com/mongodb/mongo/commit/8ccedeceb0c3d807083447301369aa3d02d80da5

Comment by Githook User [ 04/May/20 ]

Author:

{'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}

Message: SERVER-38961 remove collMod from ReplSetTest.checkReplicaSet()
Branch: master
https://github.com/mongodb/mongo/commit/01583bbf5e0884c94dcb2545be47cc3104ccbd11

Comment by Githook User [ 03/May/20 ]

Author:

{'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}

Message: SERVER-38961 remove override for causally consistent index builds
Branch: master
https://github.com/mongodb/mongo/commit/c6121c48d38446eb9951b81c29bfe921d0e1a0be

Comment by Githook User [ 03/May/20 ]

Author:

{'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}

Message: SERVER-38961 remove ReplSetTest.waitForAllIndexBuildsToFinish()
Branch: master
https://github.com/mongodb/mongo/commit/5b34bef6553fe843b0fda58094f17f96dc3598d9

Comment by Githook User [ 03/May/20 ]

Author:

{'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}

Message: SERVER-38961 remove collMod from ReplSetTest.waitForAllIndexBuildsToFinish()
Branch: master
https://github.com/mongodb/mongo/commit/881a4522ecf55dd585c0c4cf296aa750b2de000f

Comment by Githook User [ 02/May/20 ]

Author:

{'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}

Message: SERVER-38961 rollback_via_refetch_survives_nonexistent_collection_drop.js does not need to wait for rollback to finish before searching logs
Branch: master
https://github.com/mongodb/mongo/commit/0eb06f28fdb4feadc612f49b4ea63fe024b3705c

Comment by Githook User [ 01/May/20 ]

Author:

{'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}

Message: SERVER-38961 remove server parameter 'enableTwoPhaseIndexBuild'
Branch: master
https://github.com/mongodb/mongo/commit/726c65f4857fdad05075de8277c7d4a7fef92b70

Comment by Githook User [ 01/May/20 ]

Author:

{'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}

Message: SERVER-38961 remove evergreen builder for single phase index builds
Branch: master
https://github.com/mongodb/mongo/commit/92478cbbdbfd036f7d812942d55044e026b95118

Comment by Benety Goh [ 13/Apr/20 ]

Single phase index builds will still be used on empty collections but that this should not be affected by removing the collMod calls.

Comment by Benety Goh [ 13/Apr/20 ]

A small subset of index builds will still be run asynchronously until SERVER-47182 is completed.

Comment by Louis Williams [ 22/Jan/19 ]

This helper in ReplSetTest should be removed

Comment by Dianna Hohensee (Inactive) [ 11/Jan/19 ]

louis.williams, when SERVER-37270 is complete, please add more specifics to this ticket description.

Generated at Thu Feb 08 04:50:35 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.